24a3fd4c4d
Implement ClutterActorClass.has_accessible() to ensure that CallyActor does not recreate accessibles during the removal/destruction of an actor. This relies on GNOME/mutter!1083 for the ClutterActorClass.has_accessible virtual function. Running GNOME Shell for about 30 seconds results in a difference between the two runs. Before: ALLOCATED TOTAL FUNCTION [ 52.2 KiB] [ 0.05%] cally_actor_real_remove_actor [ 36.3 KiB] [ 0.04%] st_widget_get_accessible [ 9.8 KiB] [ 0.01%] atk_gobject_accessible_for_object [ 3.2 KiB] [ 0.00%] g_signal_emit_by_name [ 2.9 KiB] [ 0.00%] clutter_actor_get_children After: ALLOCATED TOTAL FUNCTION [ 1.8 KiB] [ 0.00%] cally_actor_real_remove_actor [ 1.1 KiB] [ 0.00%] clutter_actor_get_children [ 659 bytes] [ 0.00%] g_signal_emit_by_name Obviously 50KiB isn't a huge savings. Although fixing things to avoid re-entrancy on destruction can be very useful from a correctness standpoint. Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/2263
GNOME Shell
GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.
For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.
Bugs should be reported to the GNOME bug tracking system.
Contributing
To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.
Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.
License
GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.