isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Read-only mirror of https://gitlab.gnome.org/GNOME/gnome-shell
14,472 Commits 179 Branches 237 Tags 67 MiB
C 49.2%
JavaScript 47.4%
SCSS 1.4%
Meson 0.8%
Python 0.6%
Other 0.4%
118676bffb
Go to file
Jonas Dreßler 118676bffb st/theme: Unref CRStylesheet after removing old theme nodes 
Since we now remove all theme nodes on a stylesheet change (ie.
StTheme's "custom-stylesheets-changed" signal) instead of only
invalidating them, those nodes may not be accessed anymore as soon as
"custom-stylesheets-changed" is emitted.

It turned out though that when comparing them to the newly generated
nodes in `st_widget_recompute_style()` using the
`st_theme_node_paint/geometry_equal()` functions, the properties of the
old nodes will still be accessed, causing a crash since the
CRDeclarations are already freed.

To fix that, keep the reference to the CRStylesheet, which owns the
CRDeclarations used by the theme nodes, around a bit longer, so it's
still possible to access the CRDeclarations inside the
"custom-stylesheets-changed" signal handler. This allows us to compare
the old theme nodes to the new ones since the CSS properties of both are
still valid.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2709


(cherry picked from commit e06109c23c)
2020-05-01 14:32:38 +00:00
.gitlab/issue_templates gitlab: Add issue templates 2020-01-07 22:42:46 +00:00
.gitlab-ci extensions-app: Move Extensions app to new subproject 2020-03-27 23:33:30 +00:00
.settings Clean out some eclipse artefacts 2019-02-13 04:39:26 +01:00
data theme: tone down weekend with events 2020-04-28 20:04:18 +00:00
docs/reference docs: Fix interface prefix for D-Bus docs 2019-07-25 15:56:20 +02:00
js Revert "endSessionDialog: apply updates by default" 2020-04-29 19:51:05 +00:00
lint extensions-app: Move Extensions app to new subproject 2020-03-27 23:33:30 +00:00
man man: Update project website 2018-01-07 21:39:18 +01:00
meson extensionPrefs: Add application icon 2020-02-03 19:03:19 +01:00
po Update Chinese (Taiwan) translation 2020-04-30 17:31:56 +00:00
src st/theme: Unref CRStylesheet after removing old theme nodes 2020-05-01 14:32:38 +00:00
subprojects extensions-app: Rename executable 2020-04-30 00:57:27 +02:00
tests Use paint and pick context to get framebuffer 2019-12-03 19:07:15 +00:00
tools build: Remove Canberra dependency 2019-01-09 23:09:18 +00:00
.eslintrc.yml lint: Convert eslint JSON to YAML 2019-11-11 23:51:17 +00:00
.gitignore Add small gnome-shell-extension-prefs script 2020-04-30 00:57:27 +02:00
.gitlab-ci.yml ci: Build Extensions flatpak bundle 2020-03-27 23:33:30 +00:00
.gitmodules submodules: Replace non-functional git.gnome.org URL by GNOME Gitlab URL 2018-09-25 08:41:30 +02:00
config.h.meson Add check_cloexec_fds debug command 2018-07-30 23:11:41 +00:00
COPYING Changed obsolete FSF postal address. 2014-01-08 04:35:14 +07:00
gnome-shell.doap doap: Add Georges Stavracas as a maintainer 2019-12-18 15:24:38 -03:00
HACKING.md docs: Conform to coding style in HACKING guide 2020-01-06 19:53:21 +01:00
meson_options.txt extensions-app: Move Extensions app to new subproject 2020-03-27 23:33:30 +00:00
meson.build Bump version to 3.36.2 2020-04-29 22:39:21 +02:00
NEWS Bump version to 3.36.2 2020-04-29 22:39:21 +02:00
README.md README.md: Add contribution section 2019-02-13 20:37:39 +01:00

README.md

GNOME Shell

GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.

For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.

Bugs should be reported to the GNOME bug tracking system.

Contributing

To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.

Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.

License

GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.