c353914dd0
The "in" operator has a lower precedence than negation, so we are actually testing whether the favorites map contains "false". Add parentheses to get the intended behavior. Spotted by eslint. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/375
188 lines
6.1 KiB
JavaScript
188 lines
6.1 KiB
JavaScript
// -*- mode: js; js-indent-level: 4; indent-tabs-mode: nil -*-
|
|
|
|
const Shell = imports.gi.Shell;
|
|
const Signals = imports.signals;
|
|
|
|
const Main = imports.ui.main;
|
|
|
|
// In alphabetical order
|
|
const RENAMED_DESKTOP_IDS = {
|
|
'baobab.desktop': 'org.gnome.baobab.desktop',
|
|
'cheese.desktop': 'org.gnome.Cheese.desktop',
|
|
'dconf-editor.desktop': 'ca.desrt.dconf-editor.desktop',
|
|
'empathy.desktop': 'org.gnome.Empathy.desktop',
|
|
'epiphany.desktop': 'org.gnome.Epiphany.desktop',
|
|
'evolution.desktop': 'org.gnome.Evolution.desktop',
|
|
'file-roller.desktop': 'org.gnome.FileRoller.desktop',
|
|
'gcalctool.desktop': 'org.gnome.Calculator.desktop',
|
|
'geary.desktop': 'org.gnome.Geary.desktop',
|
|
'gedit.desktop': 'org.gnome.gedit.desktop',
|
|
'glchess.desktop': 'gnome-chess.desktop',
|
|
'glines.desktop': 'five-or-more.desktop',
|
|
'gnect.desktop': 'four-in-a-row.desktop',
|
|
'gnibbles.desktop': 'org.gnome.Nibbles.desktop',
|
|
'gnobots2.desktop': 'gnome-robots.desktop',
|
|
'gnome-boxes.desktop': 'org.gnome.Boxes.desktop',
|
|
'gnome-calculator.desktop': 'org.gnome.Calculator.desktop',
|
|
'gnome-clocks.desktop': 'org.gnome.clocks.desktop',
|
|
'gnome-contacts.desktop': 'org.gnome.Contacts.desktop',
|
|
'gnome-documents.desktop': 'org.gnome.Documents.desktop',
|
|
'gnome-font-viewer.desktop': 'org.gnome.font-viewer.desktop',
|
|
'gnome-nibbles.desktop': 'org.gnome.Nibbles.desktop',
|
|
'gnome-mahjongg.desktop': 'org.gnome.Mahjongg.desktop',
|
|
'gnome-music.desktop': 'org.gnome.Music.desktop',
|
|
'gnome-photos.desktop': 'org.gnome.Photos.desktop',
|
|
'gnome-screenshot.desktop': 'org.gnome.Screenshot.desktop',
|
|
'gnome-software.desktop': 'org.gnome.Software.desktop',
|
|
'gnome-terminal.desktop': 'org.gnome.Terminal.desktop',
|
|
'gnome-tweaks.desktop': 'org.gnome.tweaks.desktop',
|
|
'gnome-weather.desktop': 'org.gnome.Weather.Application.desktop',
|
|
'gnomine.desktop': 'gnome-mines.desktop',
|
|
'gnotravex.desktop': 'gnome-tetravex.desktop',
|
|
'gnotski.desktop': 'gnome-klotski.desktop',
|
|
'gtali.desktop': 'tali.desktop',
|
|
'iagno.desktop': 'org.gnome.Iagno.desktop',
|
|
'nautilus.desktop': 'org.gnome.Nautilus.desktop',
|
|
'polari.desktop': 'org.gnome.Polari.desktop',
|
|
'totem.desktop': 'org.gnome.Totem.desktop',
|
|
'evince.desktop': 'org.gnome.Evince.desktop',
|
|
};
|
|
|
|
class AppFavorites {
|
|
constructor() {
|
|
this.FAVORITE_APPS_KEY = 'favorite-apps';
|
|
this._favorites = {};
|
|
global.settings.connect('changed::' + this.FAVORITE_APPS_KEY, this._onFavsChanged.bind(this));
|
|
this.reload();
|
|
}
|
|
|
|
_onFavsChanged() {
|
|
this.reload();
|
|
this.emit('changed');
|
|
}
|
|
|
|
reload() {
|
|
let ids = global.settings.get_strv(this.FAVORITE_APPS_KEY);
|
|
let appSys = Shell.AppSystem.get_default();
|
|
|
|
// Map old desktop file names to the current ones
|
|
let updated = false;
|
|
ids = ids.map(id => {
|
|
let newId = RENAMED_DESKTOP_IDS[id];
|
|
if (newId !== undefined &&
|
|
appSys.lookup_app(newId) != null) {
|
|
updated = true;
|
|
return newId;
|
|
}
|
|
return id;
|
|
});
|
|
// ... and write back the updated desktop file names
|
|
if (updated)
|
|
global.settings.set_strv(this.FAVORITE_APPS_KEY, ids);
|
|
|
|
let apps = ids.map(id => appSys.lookup_app(id))
|
|
.filter(app => app != null);
|
|
this._favorites = {};
|
|
for (let i = 0; i < apps.length; i++) {
|
|
let app = apps[i];
|
|
this._favorites[app.get_id()] = app;
|
|
}
|
|
}
|
|
|
|
_getIds() {
|
|
let ret = [];
|
|
for (let id in this._favorites)
|
|
ret.push(id);
|
|
return ret;
|
|
}
|
|
|
|
getFavoriteMap() {
|
|
return this._favorites;
|
|
}
|
|
|
|
getFavorites() {
|
|
let ret = [];
|
|
for (let id in this._favorites)
|
|
ret.push(this._favorites[id]);
|
|
return ret;
|
|
}
|
|
|
|
isFavorite(appId) {
|
|
return appId in this._favorites;
|
|
}
|
|
|
|
_addFavorite(appId, pos) {
|
|
if (appId in this._favorites)
|
|
return false;
|
|
|
|
let app = Shell.AppSystem.get_default().lookup_app(appId);
|
|
|
|
if (!app)
|
|
return false;
|
|
|
|
let ids = this._getIds();
|
|
if (pos == -1)
|
|
ids.push(appId);
|
|
else
|
|
ids.splice(pos, 0, appId);
|
|
global.settings.set_strv(this.FAVORITE_APPS_KEY, ids);
|
|
return true;
|
|
}
|
|
|
|
addFavoriteAtPos(appId, pos) {
|
|
if (!this._addFavorite(appId, pos))
|
|
return;
|
|
|
|
let app = Shell.AppSystem.get_default().lookup_app(appId);
|
|
|
|
Main.overview.setMessage(_("%s has been added to your favorites.").format(app.get_name()),
|
|
{ forFeedback: true,
|
|
undoCallback: () => {
|
|
this._removeFavorite(appId);
|
|
}
|
|
});
|
|
}
|
|
|
|
addFavorite(appId) {
|
|
this.addFavoriteAtPos(appId, -1);
|
|
}
|
|
|
|
moveFavoriteToPos(appId, pos) {
|
|
this._removeFavorite(appId);
|
|
this._addFavorite(appId, pos);
|
|
}
|
|
|
|
_removeFavorite(appId) {
|
|
if (!(appId in this._favorites))
|
|
return false;
|
|
|
|
let ids = this._getIds().filter(id => id != appId);
|
|
global.settings.set_strv(this.FAVORITE_APPS_KEY, ids);
|
|
return true;
|
|
}
|
|
|
|
removeFavorite(appId) {
|
|
let ids = this._getIds();
|
|
let pos = ids.indexOf(appId);
|
|
|
|
let app = this._favorites[appId];
|
|
if (!this._removeFavorite(appId))
|
|
return;
|
|
|
|
Main.overview.setMessage(_("%s has been removed from your favorites.").format(app.get_name()),
|
|
{ forFeedback: true,
|
|
undoCallback: () => {
|
|
this._addFavorite(appId, pos);
|
|
}
|
|
});
|
|
}
|
|
};
|
|
Signals.addSignalMethods(AppFavorites.prototype);
|
|
|
|
var appFavoritesInstance = null;
|
|
function getAppFavorites() {
|
|
if (appFavoritesInstance == null)
|
|
appFavoritesInstance = new AppFavorites();
|
|
return appFavoritesInstance;
|
|
}
|