isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
wip/jimmac/osd-sync-with-gtk
gnome-shell/js/ui
History
Florian Müllner 4e5ca6d376 dash: Fix messed up icon height 
When determining the biggest icon size that fits the available height,
we first subtract the additional space requirements of icons (spacing,
padding, running indicator etc.) and then divide the result by the
number of icons to get the maximum size available to each icon texture.

In the above, the additional space requirement of each icon is taken
from the first icon (as all icons are assumed to be the same), and
calculated as the difference between the icon button's preferred height
and the currently used icon size.

To make sure that the icon is actually using the dash's current icon
size (even while animating to a new icon size), we enforce its height
during the size request and restore its original height afterwards.

However after some recent changes, that step is causing troubles:
For some reason, the original height may be 0, and when we restore it,
we end up forcing a fixed non-height that bypasses the regular size
request machinery.

While it is unclear where exactly the zero height comes from (maybe
waiting for a valid resource scale?), it is clear that it's best
to avoid forcing a fixed height. So instead of making the icon
texture comply with the assumed icon size, adjust the calculations
to use its current height request.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/1053
2019-04-13 14:17:07 +00:00
..
components automountManager: Fix playing disconnected sound 2019-03-04 14:39:40 +01:00
status network: Catch errors when reading devices 2019-03-27 15:06:49 +00:00
accessDialog.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
altTab.js windowCycler: Create settings before chaining up 2019-03-18 09:48:02 +00:00
animation.js animation: Reload sliced texture on global scale change 2019-03-01 17:12:53 +00:00
appDisplay.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
appFavorites.js appFavorites: Update RENAMED_DESKTOP_IDS 2019-04-11 23:28:49 +02:00
audioDeviceSelection.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
background.js background: Don't set background actor sizing and scaling 2019-03-01 17:12:53 +00:00
backgroundMenu.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
barLevel.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
boxpointer.js boxpointer: Compute source allocation and work area just once 2019-04-11 19:38:17 +00:00
calendar.js calendar: Load interface description from resource 2019-02-13 17:58:36 +00:00
checkBox.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
closeDialog.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
ctrlAltTab.js st-texture-cache: use StImageContent for cairo bound surface 2019-03-01 17:12:53 +00:00
dash.js dash: Fix messed up icon height 2019-04-13 14:17:07 +00:00
dateMenu.js dateMenu: Make clock offsets relative to local time 2019-04-13 12:11:14 +00:00
dialog.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
dnd.js dnd: Multiply drag threshold by output scale 2019-03-13 17:22:35 +00:00
edgeDragAction.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
endSessionDialog.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
environment.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
extensionDownloader.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
extensionSystem.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
focusCaretTracker.js cleanup: Port non-GObject classes to JS6 classes 2019-01-25 14:02:44 +00:00
grabHelper.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
ibusCandidatePopup.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
iconGrid.js iconGrid: Chain up in style-changed 2019-03-27 18:10:52 +01:00
inhibitShortcutsDialog.js inhibitShortcuts: Save choice in permission store 2019-03-04 10:12:58 +01:00
kbdA11yDialog.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
keyboard.js keyboard: Add bottom emoji panel row to separate aspect container 2019-03-05 21:11:47 +00:00
layout.js layout: Use an invisible but mapped actor as dummy cursor 2019-04-11 19:38:17 +00:00
lightbox.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
lookingGlass.js lookingGlass: Use symbolic icon for close button 2019-02-28 16:21:38 +01:00
magnifier.js st/settings: Add magnifier activation property and bind to settings 2019-04-02 20:28:54 +00:00
magnifierDBus.js cleanup: Port non-GObject classes to JS6 classes 2019-01-25 14:02:44 +00:00
main.js main: Wait for startup completion before running perf script 2019-03-21 10:18:02 +00:00
messageList.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
messageTray.js messageTray: Add source policy setter 2019-03-03 08:58:56 +00:00
modalDialog.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
mpris.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
notificationDaemon.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
osdMonitorLabeler.js shellDBus: Remove ShowMonitorLabels API 2019-04-11 17:49:40 +00:00
osdWindow.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
overview.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
overviewControls.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
padOsd.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
pageIndicators.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
panel.js panel: Remove left-over Gtk.Settings 2019-04-11 17:27:50 +00:00
panelMenu.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
pointerWatcher.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
popupMenu.js popupMenu: Respect items' :can-focus property 2019-02-09 14:48:27 +00:00
remoteSearch.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
runDialog.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
screencast.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
screenShield.js screenShield: Handle signal 'StatusChanged' when lockscreen is active 2019-03-18 08:32:54 +08:00
screenshot.js screenshot: Don't pick up rubberband style from GTK 2019-04-11 17:27:50 +00:00
scripting.js scripting: Don't use legacy API 2019-03-21 10:18:02 +00:00
search.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
sessionMode.js cleanup: Clean up unused imports 2019-02-09 05:05:07 +01:00
shellDBus.js shellDBus: Accept connector to restrict OSD to one monitor 2019-04-11 18:53:53 +00:00
shellEntry.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
shellMountOperation.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
slider.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
switcherPopup.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
switchMonitor.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
tweener.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
unlockDialog.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
userWidget.js userWidget: Fix avatar size 2019-03-12 00:34:04 +00:00
viewSelector.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
windowAttentionHandler.js windowAttentionHandler: Don't destroy on open 2019-03-02 22:09:33 +01:00
windowManager.js windowManager: Don't move sticky windows when inserting workspace 2019-04-11 19:00:52 +00:00
windowMenu.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
workspace.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
workspacesView.js workspacesView: Support touch/touchpad gestures to switch workspaces 2019-04-11 17:00:17 +00:00
workspaceSwitcherPopup.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
workspaceThumbnail.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
xdndHandler.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00