gnome-shell/js
Florian Müllner 059af4c4cd a11y: Change HC icon theme first
There are two ways for applications to provide a high contrast icon:

 1. install an icon into the HighContrast theme
 2. install a symbolic icon into the default hicolor theme

The latter is preferred nowadays, and implemented in the high-contrast
CSS variant by enforcing the symbolic icon style.

However together with the way we currently enable/disable high-contrast,
this can lead to the following race:
 1. the GTK theme is changed from HighContrast
 2. we reload the default stylesheet
 3. the icon style changes to "regular", so we request a
    new icon from the HighContrast icon theme
 4. the icon theme is changed from HighContrast
 5. we evict existing icons from the cache
 6. we reload icons for the new icon theme; however as we
    find a pending request (from 3), we re-use it
 7. the request from 3 finishes, and we end up with a
    wrong icon in the cache

The simplest fix is to change the icon theme before the GTK theme: Unlike the
theme name, the icon style is encoded in the cache key, so we won't re-use
an old (and incorrect) request in that case.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/2414
2020-03-31 01:12:34 +02:00
..
extensionPrefs cleanup: Use consistent brace style of blocks 2019-09-15 16:02:45 +02:00
gdm loginDialog: Stop using deprecated actor property 2019-09-20 16:58:00 +00:00
misc networkAgent: Drop VPN plugin cache 2020-03-17 19:37:54 +01:00
perf cleanup: Disambiguate assignments in arrow functions 2019-09-15 16:02:45 +02:00
portalHelper cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
ui a11y: Change HC icon theme first 2020-03-31 01:12:34 +02:00
js-resources.gresource.xml accessibility: Add pointer accessibility support 2019-06-06 09:13:29 +02:00
meson.build build: Use dedicated resources for helper programs 2018-08-14 17:28:04 +00:00
portal-resources.gresource.xml build: Include params.js in portal-helper gresources 2018-10-23 15:38:31 +00:00
prefs-resources.gresource.xml build: Use dedicated resources for helper programs 2018-08-14 17:28:04 +00:00