Florian Müllner
cbbc066d6f
powerProfiles: Avoid warnings on missing power-profiles-daemon
...
GDBusProxy transparently handles the remote object appearing and
vanishing. It is therefore not an error if the service is not
running at the time the proxy is initialized, so we proceed and
try to read the list of profiles which is null in that case,
resulting in (harmless but annoying) warnings.
Avoid this by only reading the initial list of profiles if the
service has a name owner.
https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5992
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2518 >
2022-10-20 13:55:06 +02:00
Alessandro Bono
ade4b23796
cleanup: Minimize deep_unpack() usage
...
deep_unpack()[1] will unpack a variant and its children, but only up to one level.
lookup_value()[2] will directly search for a value with a linear scan.
Performing a deep_unpack() + lookup can be a more expensive operation when we are
looking for just a single value compared to just perform the lookup_value() directly
in C. Avoid the deep_unpack() usage when we perform a single check presence.
[1] https://gjs.guide/guides/glib/gvariant.html#deepunpack
[2] https://docs.gtk.org/glib/method.Variant.lookup_value.html
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2416 >
2022-08-10 10:29:24 +00:00
Florian Müllner
1f178e83d3
status/powerProfiles: Port to quick settings
...
With menu support in place, this is now a straight-forward port:
Just add the existing profiles section to a QuickToggleMenu instead
of a submenu item.
The toggle itself now switches between 'balanced' and the last used
non-default profile.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2393 >
2022-08-03 12:41:05 +00:00
Florian Müllner
4f155d3757
status/powerProfiles: Remember last selected non-default profile
...
When we move to quick settings, this will allow us to toggle
between two profiles even where more profiles are available.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2391 >
2022-08-01 12:33:36 +00:00
Florian Müllner
6aa3a2f4e2
status/powerProfiles: Use CHECK ornament
...
The design team prefers them over dots in this context now.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2389 >
2022-07-27 13:39:02 +00:00
Florian Müllner
d555be0a64
status/powerProfiles: Add image to menu items
...
We want the icons when we move to quick settings:
https://gitlab.gnome.org/Teams/Design/os-mockups/-/raw/master/system-status/quick-settings/quick-toggles-mvp.png
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2389 >
2022-07-27 13:39:02 +00:00
Florian Müllner
d03a94dab1
status/powerProfiles: Split updating profiles from sync
...
Calling the split out code where necessary seems cleaner than
calling it conditionally as part of the general sync().
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2389 >
2022-07-27 13:39:02 +00:00
Bastien Nocera
b83b22bc58
powerProfiles: Remove support for power-profiles-daemon < 0.9.0
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2101 >
2022-02-08 11:21:44 +00:00
Florian Müllner
19fc6ef5dd
powerProfiles: Tweak profile names
...
After some more discussion, we settled on slightly different
profile names.
https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4530
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1939 >
2021-08-09 13:50:13 +00:00
Florian Müllner
f1320bd250
status/powerProfiles: Add power mode selection
...
Settings' power panel gained support for switchable power profiles
in GNOME 40. It's useful to have that functionality more readily
available, so expose it in the system status menu as well.
https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3944
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1907 >
2021-08-02 16:41:06 +02:00
