From fd99d13f04b4618462a218d1476f820f182626e5 Mon Sep 17 00:00:00 2001 From: "Jasper St. Pierre" Date: Thu, 16 Feb 2012 17:23:16 -0500 Subject: [PATCH] messageTray: Correctly show the icon on a notification stack An actor is removed from its parent after it emits the destroy signal, so we can't just check if the notification stack has more than one notification -- we need to check if there's a notification there that is not the current one. This was causing spew in the form of: "this.notificationStack.get_children()[0]._delegate.setIconVisible is not a function" --- js/ui/messageTray.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js index 1c7f0bab4..9ccc6e4f7 100644 --- a/js/ui/messageTray.js +++ b/js/ui/messageTray.js @@ -1327,8 +1327,9 @@ const SummaryItem = new Lang.Class({ } } - if (this.notificationStack.get_children().length > 0) - this.notificationStack.get_children()[0]._delegate.setIconVisible(true); + let firstNotification = this._stackedNotifications[0]; + if (firstNotification) + firstNotification.notification.setIconVisible(true); } }); Signals.addSignalMethods(SummaryItem.prototype);