From fa3284232f563473d1b30e5eac8bf9d530f63a81 Mon Sep 17 00:00:00 2001 From: Debarshi Ray Date: Fri, 6 Dec 2013 12:56:43 +0100 Subject: [PATCH] remoteSearch: Let remote search providers not provide an icon The documentation indicates that they are optional, so let us make the code behave accordingly. https://bugzilla.gnome.org/show_bug.cgi?id=719965 --- js/ui/remoteSearch.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/js/ui/remoteSearch.js b/js/ui/remoteSearch.js index f48a37fa5..c99e812aa 100644 --- a/js/ui/remoteSearch.js +++ b/js/ui/remoteSearch.js @@ -191,7 +191,9 @@ const RemoteSearchProvider = new Lang.Class({ }, createIcon: function(size, meta) { - let gicon; + let gicon = null; + let icon = null; + if (meta['icon']) { gicon = Gio.icon_deserialize(meta['icon']); } else if (meta['gicon']) { @@ -203,8 +205,10 @@ const RemoteSearchProvider = new Lang.Class({ bitsPerSample, width, height, rowStride); } - return new St.Icon({ gicon: gicon, - icon_size: size }); + if (gicon) + icon = new St.Icon({ gicon: gicon, + icon_size: size }); + return icon; }, filterResults: function(results, maxNumber) {