isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

modalDialog: Consistently return correct boolean for open() in ModalDialogs

Browse Source 
Previously these calls either ignored the return from super.open() or
implicitely returned false.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2038>
This commit is contained in:
Evan Welsh 2021-10-30 15:08:12 -07:00 committed by Marge Bot
parent 75e57749f0
commit f8f37e0161
3 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/ui/accessDialog.js
View File

@ -76,10 +76,12 @@ class AccessDialog extends ModalDialog.ModalDialog {
} }
open() { open() {
super.open(); if (!super.open())
return false;
let connection = this._invocation.get_connection(); let connection = this._invocation.get_connection();
this._requestExported = this._request.export(connection, this._handle); this._requestExported = this._request.export(connection, this._handle);
return true;
} }
CloseAsync(invocation, _params) { CloseAsync(invocation, _params) {

4
js/ui/runDialog.js
View File

@ -249,8 +249,8 @@ class RunDialog extends ModalDialog.ModalDialog {
this._commandError = false; this._commandError = false;
if (this._lockdownSettings.get_boolean(DISABLE_COMMAND_LINE_KEY)) if (this._lockdownSettings.get_boolean(DISABLE_COMMAND_LINE_KEY))
return; return false;
super.open(); return super.open();
} }
}); });

4
js/ui/welcomeDialog.js
View File

@ -26,9 +26,9 @@ class WelcomeDialog extends ModalDialog.ModalDialog {
open() { open() {
if (!this._tourAppInfo) if (!this._tourAppInfo)
return; return false;
super.open(); return super.open();
} }
_buildLayout() { _buildLayout() {