From f812e9be7dede591bba082ffb8c141373f9ec6c0 Mon Sep 17 00:00:00 2001 From: Cosimo Cecchi Date: Sat, 14 Mar 2015 15:44:54 -0700 Subject: [PATCH] ShellApp: use st_icon_set_fallback_icon_name() to specify app fallback We can now safely pass a NULL GIcon to st_icon_set_gicon(), and specify a more generic fallback using the new API we just introduced. https://bugzilla.gnome.org/show_bug.cgi?id=746219 --- src/shell-app.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/shell-app.c b/src/shell-app.c index abea69ffa..9c03a4ad8 100644 --- a/src/shell-app.c +++ b/src/shell-app.c @@ -216,18 +216,10 @@ shell_app_create_icon_texture (ShellApp *app, ret = st_icon_new (); st_icon_set_icon_size (ST_ICON (ret), size); + st_icon_set_fallback_icon_name (ST_ICON (ret), "application-x-executable"); icon = g_app_info_get_icon (G_APP_INFO (app->info)); - if (icon != NULL) - { - st_icon_set_gicon (ST_ICON (ret), icon); - } - else - { - icon = g_themed_icon_new ("application-x-executable"); - st_icon_set_gicon (ST_ICON (ret), icon); - g_object_unref (icon); - } + st_icon_set_gicon (ST_ICON (ret), icon); return ret; }