From f5d793647ba0f813d65241cd53cdc418a9d54498 Mon Sep 17 00:00:00 2001 From: Sebastian Keller Date: Tue, 20 Dec 2022 13:49:59 +0100 Subject: [PATCH] overview: Skip SHOWN to SHOWN when changing from app grid to overview Switching between the app grid and the window picker in the overview via gestures results in _gestureEnd() getting called with endProgress !== 0 in both cases, which leads to it calling _showDone(). This then unconditionally changes the state to SHOWN, which in this situation is already the current state. Since the previous commit this results in a warning, so check if we are already in the SHOWN state. Part-of: --- js/ui/overview.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/js/ui/overview.js b/js/ui/overview.js index 4966cdb69..4dd59d4ae 100644 --- a/js/ui/overview.js +++ b/js/ui/overview.js @@ -573,7 +573,9 @@ var Overview = class extends Signals.EventEmitter { this._animationInProgress = false; this._coverPane.hide(); - this._changeShownState(OverviewShownState.SHOWN); + if (this._shownState !== OverviewShownState.SHOWN) + this._changeShownState(OverviewShownState.SHOWN); + // Handle any calls to hide* while we were showing if (!this._shown) this._animateNotVisible();