isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

system: Don't execute Settings

Browse Source 
In a9ad91c831, a bug was introduced in the following code:

```c
            this._settingsAction.connect('clicked',
                                         this._onSettingsClicked().bind(this));
```

Notice that the callback is being executed! This commit
fixes that by removing the '()' from the callback.
This commit is contained in:
Georges Basile Stavracas Neto 2018-07-31 13:23:05 -03:00
parent 7ca418a79a
commit f433b12d6e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/ui/status/system.js
View File

@ -269,7 +269,7 @@ var Indicator = new Lang.Class({
app.get_name()]; app.get_name()];
this._settingsAction = this._createActionButton(icon, name); this._settingsAction = this._createActionButton(icon, name);
this._settingsAction.connect('clicked', this._settingsAction.connect('clicked',
this._onSettingsClicked().bind(this)); this._onSettingsClicked.bind(this));
} else { } else {
log('Missing required core component Settings, expect trouble…'); log('Missing required core component Settings, expect trouble…');
this._settingsAction = new St.Widget(); this._settingsAction = new St.Widget();