From f3fcc4adb7ccdb61d88dba64a2d74d8a95088a13 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Florian=20M=C3=BCllner?= <fmuellner@gnome.org>
Date: Sat, 28 Mar 2020 18:55:17 +0100
Subject: [PATCH] shellDBus: Return error from ReloadExtension

The method has been deprecated because it generally doesn't (and
can't) work. Clarify that by returning an error instead of
apparently doing nothing.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2510
---
 js/ui/shellDBus.js | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/js/ui/shellDBus.js b/js/ui/shellDBus.js
index 2b6b2ae96..f64081b24 100644
--- a/js/ui/shellDBus.js
+++ b/js/ui/shellDBus.js
@@ -329,12 +329,11 @@ var GnomeShellExtensions = class {
             (conn, res) => conn.call_finish(res));
     }
 
-    ReloadExtension(uuid) {
-        let extension = Main.extensionManager.lookup(uuid);
-        if (!extension)
-            return;
-
-        Main.extensionManager.reloadExtension(extension);
+    ReloadExtensionAsync(params, invocation) {
+        invocation.return_error_literal(
+            Gio.DBusError,
+            Gio.DBusError.NOT_SUPPORTED,
+            'ReloadExtension is deprecated and does not work');
     }
 
     CheckForUpdates() {