From f14960ff0314167e10d31196654feae244cd8631 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Wed, 4 Aug 2021 00:24:41 +0200 Subject: [PATCH] extensionDownloader: Stop setting proxy resolver explicitly MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Quoting the documentation: In libsoup 2.44 and later, you can set the session's “proxy-resolver” property to the resolver returned by g_proxy_resolver_get_default() to get the same effect. Note that for "plain" SoupSessions (ie, not SoupSessionAsync or SoupSessionSync), this is done for you automatically. libsoup 2.44 was released in 2013, so we can safely assume that Soup is new enough to handle this for us. Part-of: --- js/ui/extensionDownloader.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/js/ui/extensionDownloader.js b/js/ui/extensionDownloader.js index 3b64ec4b9..08cea5931 100644 --- a/js/ui/extensionDownloader.js +++ b/js/ui/extensionDownloader.js @@ -253,8 +253,4 @@ class InstallExtensionDialog extends ModalDialog.ModalDialog { function init() { _httpSession = new Soup.Session({ ssl_use_system_ca_file: true }); - - // See: https://bugzilla.gnome.org/show_bug.cgi?id=655189 for context. - // _httpSession.add_feature(new Soup.ProxyResolverDefault()); - Soup.Session.prototype.add_feature.call(_httpSession, new Soup.ProxyResolverDefault()); }