isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

extensionDownloader: Fix check for updates with several extensions

Browse Source 
When having several extensions installed checking for updates fails.
This is because we are using GET and query params and since we are
sending all the metadata of the extension the server returns 502
when the URL is too long. This error code is ignored safely.

It is only needed to send the version of the extension to check if it
has updates.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2962
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1363
This commit is contained in:
Jeremias Ortega 2020-07-13 22:38:25 -06:00
parent 95bb194356
commit f0d2509dc3
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/ui/extensionDownloader.js
View File

@ -139,7 +139,9 @@ function checkForUpdates() {
return; return;
if (extension.hasUpdate) if (extension.hasUpdate)
return; return;
metadatas[uuid] = extension.metadata; metadatas[uuid] = {
version: extension.metadata.version,
};
}); });
if (Object.keys(metadatas).length === 0) if (Object.keys(metadatas).length === 0)