From e92a6b3c6cd7bec438cb7fc87426208d3dd5cb45 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Sun, 29 Jul 2012 12:06:17 +0200 Subject: [PATCH] workspacesView: Avoid an unnecessary animation Currently we animate scrolling to the active workspace both when the number of workspaces changed and after changing the active workspace. So in case we don't actually change workspace, this results in an unnecessary animation that may even have unwanted side effects: when done during the overview transition (e.g. in the case of opening and activating a window on an empty workspace), non-active workspaces become visible during the transition. To fix, don't scroll to the active workspace when the number of workspaces changes and rely on the 'switch-workspace' signal being emitted as necessary. https://bugzilla.gnome.org/show_bug.cgi?id=682002 --- js/ui/workspacesView.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/js/ui/workspacesView.js b/js/ui/workspacesView.js index f769186fb..2b5eac5bc 100644 --- a/js/ui/workspacesView.js +++ b/js/ui/workspacesView.js @@ -317,8 +317,6 @@ const WorkspacesView = new Lang.Class({ this._updateWorkspaceActors(false); } - - this._scrollToActive(true); }, _activeWorkspaceChanged: function(wm, from, to, direction) {