isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

workspacesView: Rename show to animateToOverview

Browse Source 
WorkspacesDisplay is a ClutterActor subclass, and overriding
the show and hide methods require chaining up, otherwise the
actor isn't actually shown or hidden.

To avoid clashing with the pre-existing show method, rename
to animateToOverview.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1295
This commit is contained in:
Georges Basile Stavracas Neto 2020-06-01 12:20:44 -03:00
parent fe131f926d
commit e7ec373aee
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/ui/viewSelector.js
View File

@ -273,7 +273,7 @@ var ViewSelector = GObject.registerClass({
show() { show() {
this.reset(); this.reset();
this._workspacesDisplay.show(this._showAppsButton.checked); this._workspacesDisplay.animateToOverview(this._showAppsButton.checked);
this._activePage = null; this._activePage = null;
if (this._showAppsButton.checked) if (this._showAppsButton.checked)
this._showPage(this._appsPage); this._showPage(this._appsPage);

2
js/ui/workspacesView.js
View File

@ -608,7 +608,7 @@ class WorkspacesDisplay extends St.Widget {
return this._getPrimaryView().navigate_focus(from, direction, false); return this._getPrimaryView().navigate_focus(from, direction, false);
} }
show(fadeOnPrimary) { animateToOverview(fadeOnPrimary) {
this._updateWorkspacesViews(); this._updateWorkspacesViews();
for (let i = 0; i < this._workspacesViews.length; i++) { for (let i = 0; i < this._workspacesViews.length; i++) {
let animationType; let animationType;