isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

extensionSystem: Check if extension exists before accessing property

Browse Source 
If the extension doesn't exist in the `this._extensions` Map, we'd try
to access `extension.dir` on undefined/null. So set the `dir` variable
after checking if `extension` is defined.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/96
This commit is contained in:
Jonas Dreßler 2019-09-11 14:36:18 +02:00 committed by Florian Müllner
parent 2a32fb2e72
commit e76877c4b8
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
js/ui/extensionSystem.js
View File

@ -303,11 +303,10 @@ var ExtensionManager = class {
_callExtensionInit(uuid) { _callExtensionInit(uuid) {
let extension = this.lookup(uuid); let extension = this.lookup(uuid);
let dir = extension.dir;
if (!extension) if (!extension)
throw new Error("Extension was not properly created. Call createExtensionObject first"); throw new Error("Extension was not properly created. Call createExtensionObject first");
let dir = extension.dir;
let extensionJs = dir.get_child('extension.js'); let extensionJs = dir.get_child('extension.js');
if (!extensionJs.query_exists(null)) { if (!extensionJs.query_exists(null)) {
this.logExtensionError(uuid, new Error('Missing extension.js')); this.logExtensionError(uuid, new Error('Missing extension.js'));