From e56d7f502152b4d2271fa828179856cb7a7f4fb1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Thu, 31 Jan 2019 15:04:56 +0100 Subject: [PATCH] cleanup: Remove unused variables Spotted by eslint. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/607 --- js/gdm/loginDialog.js | 6 ------ js/gdm/realmd.js | 8 ++++---- js/misc/extensionUtils.js | 2 -- js/misc/fileUtils.js | 4 ++-- js/misc/objectManager.js | 2 -- js/perf/core.js | 1 - js/portalHelper/main.js | 1 - js/ui/altTab.js | 1 - js/ui/appDisplay.js | 17 +---------------- js/ui/background.js | 1 - js/ui/calendar.js | 4 +--- js/ui/components/networkAgent.js | 2 -- js/ui/ctrlAltTab.js | 1 - js/ui/dateMenu.js | 1 - js/ui/endSessionDialog.js | 6 +----- js/ui/extensionDownloader.js | 2 -- js/ui/iconGrid.js | 5 ----- js/ui/keyboard.js | 11 +---------- js/ui/lookingGlass.js | 3 --- js/ui/magnifier.js | 6 +----- js/ui/main.js | 3 +-- js/ui/osdMonitorLabeler.js | 2 -- js/ui/pointerA11yTimeout.js | 2 -- js/ui/runDialog.js | 2 -- js/ui/screenShield.js | 2 -- js/ui/slider.js | 7 ++----- js/ui/status/volume.js | 2 -- js/ui/userWidget.js | 6 +----- js/ui/viewSelector.js | 1 - js/ui/windowManager.js | 1 - js/ui/workspace.js | 2 -- js/ui/workspaceThumbnail.js | 4 +--- js/ui/workspacesView.js | 1 - 33 files changed, 16 insertions(+), 103 deletions(-) diff --git a/js/gdm/loginDialog.js b/js/gdm/loginDialog.js index fe6ca9aa6..032bac6d6 100644 --- a/js/gdm/loginDialog.js +++ b/js/gdm/loginDialog.js @@ -187,8 +187,6 @@ var UserList = class { } updateStyle(isExpanded) { - let tasks = []; - if (isExpanded) this._box.add_style_pseudo_class('expanded'); else @@ -575,19 +573,15 @@ var LoginDialog = GObject.registerClass({ // First find out what space the children require let bannerAllocation = null; let bannerHeight = 0; - let bannerWidth = 0; if (this._bannerView.visible) { bannerAllocation = this._getBannerAllocation(dialogBox, this._bannerView); bannerHeight = bannerAllocation.y2 - bannerAllocation.y1; - bannerWidth = bannerAllocation.x2 - bannerAllocation.x1; } let authPromptAllocation = null; - let authPromptHeight = 0; let authPromptWidth = 0; if (this._authPrompt.actor.visible) { authPromptAllocation = this._getCenterActorAllocation(dialogBox, this._authPrompt.actor); - authPromptHeight = authPromptAllocation.y2 - authPromptAllocation.y1; authPromptWidth = authPromptAllocation.x2 - authPromptAllocation.x1; } diff --git a/js/gdm/realmd.js b/js/gdm/realmd.js index 50f3c5899..4ec64edff 100644 --- a/js/gdm/realmd.js +++ b/js/gdm/realmd.js @@ -36,10 +36,10 @@ var Manager = class { return; for (let i = 0; i < realmPaths.length; i++) { - let realm = Realm(Gio.DBus.system, - 'org.freedesktop.realmd', - realmPaths[i], - this._onRealmLoaded.bind(this)); + Realm(Gio.DBus.system, + 'org.freedesktop.realmd', + realmPaths[i], + this._onRealmLoaded.bind(this)); } } diff --git a/js/misc/extensionUtils.js b/js/misc/extensionUtils.js index 89a085d68..51272e49c 100644 --- a/js/misc/extensionUtils.js +++ b/js/misc/extensionUtils.js @@ -162,8 +162,6 @@ function isOutOfDate(extension) { } function createExtensionObject(uuid, dir, type) { - let info; - let metadataFile = dir.get_child('metadata.json'); if (!metadataFile.query_exists(null)) { throw new Error('Missing metadata.json'); diff --git a/js/misc/fileUtils.js b/js/misc/fileUtils.js index 64884162d..81fdae0e4 100644 --- a/js/misc/fileUtils.js +++ b/js/misc/fileUtils.js @@ -36,7 +36,7 @@ function recursivelyDeleteDir(dir, deleteParent) { let children = dir.enumerate_children('standard::name,standard::type', Gio.FileQueryInfoFlags.NONE, null); - let info, child; + let info; while ((info = children.next_file(null)) != null) { let type = info.get_file_type(); let child = dir.get_child(info.get_name()); @@ -57,7 +57,7 @@ function recursivelyMoveDir(srcDir, destDir) { if (!destDir.query_exists(null)) destDir.make_directory_with_parents(null); - let info, child; + let info; while ((info = children.next_file(null)) != null) { let type = info.get_file_type(); let srcChild = srcDir.get_child(info.get_name()); diff --git a/js/misc/objectManager.js b/js/misc/objectManager.js index 56b4cc9b4..cd531d390 100644 --- a/js/misc/objectManager.js +++ b/js/misc/objectManager.js @@ -92,7 +92,6 @@ var ObjectManager = class { proxy.init_async(GLib.PRIORITY_DEFAULT, this._cancellable, (initable, result) => { - let error = null; try { initable.init_finish(result); } catch(e) { @@ -155,7 +154,6 @@ var ObjectManager = class { } _onManagerProxyLoaded(initable, result) { - let error = null; try { initable.init_finish(result); } catch(e) { diff --git a/js/perf/core.js b/js/perf/core.js index 04ea3c49f..2f78fde07 100644 --- a/js/perf/core.js +++ b/js/perf/core.js @@ -136,7 +136,6 @@ let overviewFrames; let overviewLatency; let mallocUsedSize = 0; let overviewShowCount = 0; -let firstOverviewUsedSize; let haveSwapComplete = false; let applicationsShowStart; let applicationsShowCount = 0; diff --git a/js/portalHelper/main.js b/js/portalHelper/main.js index e163d6574..eae433a69 100644 --- a/js/portalHelper/main.js +++ b/js/portalHelper/main.js @@ -19,7 +19,6 @@ const PortalHelperSecurityLevel = { INSECURE: 2 }; -const INACTIVITY_TIMEOUT = 30000; //ms const CONNECTIVITY_CHECK_HOST = 'nmcheck.gnome.org'; const CONNECTIVITY_CHECK_URI = 'http://' + CONNECTIVITY_CHECK_HOST; const CONNECTIVITY_RECHECK_RATELIMIT_TIMEOUT = 30 * GLib.USEC_PER_SEC; diff --git a/js/ui/altTab.js b/js/ui/altTab.js index 0b0bea1ac..b5681435e 100644 --- a/js/ui/altTab.js +++ b/js/ui/altTab.js @@ -841,7 +841,6 @@ class AppSwitcher extends SwitcherPopup.SwitcherList { this._removeIcon(app); }); - let n = this._arrows.length; let arrow = new St.DrawingArea({ style_class: 'switcher-arrow' }); arrow.connect('repaint', () => { SwitcherPopup.drawArrow(arrow, St.Side.BOTTOM); }); this.add_actor(arrow); diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js index 00019772a..a06079619 100644 --- a/js/ui/appDisplay.js +++ b/js/ui/appDisplay.js @@ -20,7 +20,6 @@ const SystemActions = imports.misc.systemActions; const { loadInterfaceXML } = imports.misc.fileUtils; -var MAX_APPLICATION_WORK_MILLIS = 75; var MENU_POPUP_TIMEOUT = 600; var MAX_COLUMNS = 6; var MIN_COLUMNS = 4; @@ -34,23 +33,9 @@ var FOLDER_SUBICON_FRACTION = .4; var MIN_FREQUENT_APPS_COUNT = 3; -var INDICATORS_BASE_TIME = 0.25; -var INDICATORS_ANIMATION_DELAY = 0.125; -var INDICATORS_ANIMATION_MAX_TIME = 0.75; - var VIEWS_SWITCH_TIME = 0.4; var VIEWS_SWITCH_ANIMATION_DELAY = 0.1; -// Follow iconGrid animations approach and divide by 2 to animate out to -// not annoy the user when the user wants to quit appDisplay. -// Also, make sure we don't exceed iconGrid animation total time or -// views switch time. -var INDICATORS_BASE_TIME_OUT = 0.125; -var INDICATORS_ANIMATION_DELAY_OUT = 0.0625; -var INDICATORS_ANIMATION_MAX_TIME_OUT = - Math.min (VIEWS_SWITCH_TIME, - IconGrid.ANIMATION_TIME_OUT + IconGrid.ANIMATION_MAX_DELAY_OUT_FOR_ITEM); - var PAGE_SWITCH_TIME = 0.3; const SWITCHEROO_BUS_NAME = 'net.hadess.SwitcherooControl'; @@ -373,7 +358,7 @@ var AllView = class AllView extends BaseAppView { _loadApps() { this._appInfoList = Shell.AppSystem.get_default().get_installed().filter(appInfo => { try { - let id = appInfo.get_id(); // catch invalid file encodings + (appInfo.get_id()); // catch invalid file encodings } catch(e) { return false; } diff --git a/js/ui/background.js b/js/ui/background.js index 2a404ae9b..6ce0d6093 100644 --- a/js/ui/background.js +++ b/js/ui/background.js @@ -108,7 +108,6 @@ const PRIMARY_COLOR_KEY = 'primary-color'; const SECONDARY_COLOR_KEY = 'secondary-color'; const COLOR_SHADING_TYPE_KEY = 'color-shading-type'; const BACKGROUND_STYLE_KEY = 'picture-options'; -const PICTURE_OPACITY_KEY = 'picture-opacity'; const PICTURE_URI_KEY = 'picture-uri'; var FADE_ANIMATION_TIME = 1.0; diff --git a/js/ui/calendar.js b/js/ui/calendar.js index d7c5bc805..4996cfc30 100644 --- a/js/ui/calendar.js +++ b/js/ui/calendar.js @@ -546,8 +546,6 @@ var Calendar = class Calendar { this._calendarBegin = new Date(beginDate); this._markedAsToday = now; - let year = beginDate.getYear(); - let daysToWeekStart = (7 + beginDate.getDay() - this._weekStart) % 7; let startsOnWeekStart = daysToWeekStart == 0; let weekPadding = startsOnWeekStart ? 7 : 0; @@ -559,7 +557,7 @@ var Calendar = class Calendar { let row = 2; // nRows here means 6 weeks + one header + one navbar let nRows = 8; - while (row < 8) { + while (row < nRows) { // xgettext:no-javascript-format let button = new St.Button({ label: iter.toLocaleFormat(C_("date day number format", "%d")), can_focus: true }); diff --git a/js/ui/components/networkAgent.js b/js/ui/components/networkAgent.js index dca8318ed..892e6ca4d 100644 --- a/js/ui/components/networkAgent.js +++ b/js/ui/components/networkAgent.js @@ -236,7 +236,6 @@ class NetworkSecretDialog extends ModalDialog.ModalDialog { _get8021xSecrets(secrets) { let ieee8021xSetting = this._connection.get_setting_802_1x(); - let phase2method; /* If hints were given we know exactly what we need to ask */ if (this._settingName == "802-1x" && this._hints.length) { @@ -696,7 +695,6 @@ var NetworkAgent = class { break; case 'gsm': if (hints.includes('pin')) { - let gsmSetting = connection.get_setting_gsm(); title = _("PIN code required"); body = _("PIN code is needed for the mobile broadband device"); break; diff --git a/js/ui/ctrlAltTab.js b/js/ui/ctrlAltTab.js index 338080fc4..a075ca151 100644 --- a/js/ui/ctrlAltTab.js +++ b/js/ui/ctrlAltTab.js @@ -7,7 +7,6 @@ const SwitcherPopup = imports.ui.switcherPopup; const Params = imports.misc.params; var POPUP_APPICON_SIZE = 96; -var POPUP_FADE_TIME = 0.1; // seconds var SortGroup = { TOP: 0, diff --git a/js/ui/dateMenu.js b/js/ui/dateMenu.js index 4e8ce7d24..fad27cfd2 100644 --- a/js/ui/dateMenu.js +++ b/js/ui/dateMenu.js @@ -459,7 +459,6 @@ class CalendarColumnLayout extends Clutter.BoxLayout { var DateMenuButton = GObject.registerClass( class DateMenuButton extends PanelMenu.Button { _init() { - let item; let hbox; let vbox; diff --git a/js/ui/endSessionDialog.js b/js/ui/endSessionDialog.js index 3c7729eb3..cdba84c03 100644 --- a/js/ui/endSessionDialog.js +++ b/js/ui/endSessionDialog.js @@ -29,13 +29,9 @@ const UserWidget = imports.ui.userWidget; const { loadInterfaceXML } = imports.misc.fileUtils; -let _endSessionDialog = null; - const _ITEM_ICON_SIZE = 48; const _DIALOG_ICON_SIZE = 48; -var GSM_SESSION_MANAGER_LOGOUT_FORCE = 2; - const EndSessionDialogIface = loadInterfaceXML('org.gnome.SessionManager.EndSessionDialog'); const logoutDialogContent = { @@ -223,7 +219,7 @@ function init() { // This always returns the same singleton object // By instantiating it initially, we register the // bus object, etc. - _endSessionDialog = new EndSessionDialog(); + (new EndSessionDialog()); } var EndSessionDialog = GObject.registerClass( diff --git a/js/ui/extensionDownloader.js b/js/ui/extensionDownloader.js index dbbd10237..d86ae92af 100644 --- a/js/ui/extensionDownloader.js +++ b/js/ui/extensionDownloader.js @@ -9,8 +9,6 @@ const ExtensionSystem = imports.ui.extensionSystem; const FileUtils = imports.misc.fileUtils; const ModalDialog = imports.ui.modalDialog; -const _signals = ExtensionSystem._signals; - var REPOSITORY_URL_BASE = 'https://extensions.gnome.org'; var REPOSITORY_URL_DOWNLOAD = REPOSITORY_URL_BASE + '/download-extension/%s.shell-extension.zip'; var REPOSITORY_URL_INFO = REPOSITORY_URL_BASE + '/extension-info/'; diff --git a/js/ui/iconGrid.js b/js/ui/iconGrid.js index a6774edb1..8e5c9c60a 100644 --- a/js/ui/iconGrid.js +++ b/js/ui/iconGrid.js @@ -743,7 +743,6 @@ var IconGrid = GObject.registerClass({ this._fixedHItemSize = this._hItemSize; this._fixedVItemSize = this._vItemSize; this._updateSpacingForSize(availWidth, availHeight); - let spacing = this._getSpacing(); if (this.columnsForWidth(availWidth) < this._minColumns || this.rowsForHeight(availHeight) < this._minRows) { let neededWidth = this.usedWidthForNColumns(this._minColumns) - availWidth ; @@ -802,7 +801,6 @@ var PaginatedIconGrid = GObject.registerClass({ } let children = this._getVisibleChildren(); let availWidth = box.x2 - box.x1; - let availHeight = box.y2 - box.y1; let spacing = this._getSpacing(); let [nColumns, usedWidth] = this._computeLayout(availWidth); @@ -821,7 +819,6 @@ var PaginatedIconGrid = GObject.registerClass({ let x = box.x1 + leftEmptySpace + this.leftPadding; let y = box.y1 + this.topPadding; let columnIndex = 0; - let rowIndex = 0; for (let i = 0; i < children.length; i++) { let childBox = this._calculateChildBox(children[i], x, y, box); @@ -831,7 +828,6 @@ var PaginatedIconGrid = GObject.registerClass({ columnIndex++; if (columnIndex == nColumns) { columnIndex = 0; - rowIndex++; } if (columnIndex == 0) { y += this._getVItemSize() + spacing; @@ -863,7 +859,6 @@ var PaginatedIconGrid = GObject.registerClass({ if (this._rowLimit) nRows = Math.min(nRows, this._rowLimit); - let spacing = this._getSpacing(); // We want to contain the grid inside the parent box with padding this._rowsPerPage = this.rowsForHeight(availHeightPerPage); this._nPages = Math.ceil(nRows / this._rowsPerPage); diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js index c30f90a76..2a096f2c1 100644 --- a/js/ui/keyboard.js +++ b/js/ui/keyboard.js @@ -405,9 +405,6 @@ var Key = class Key { return Clutter.EVENT_PROPAGATE; }); button.connect('touch-event', (actor, event) => { - let device = event.get_device(); - let sequence = event.get_event_sequence(); - // We only handle touch events here on wayland. On X11 // we do get emulated pointer events, which already works // for single-touch cases. Besides, the X11 passive touch grab @@ -913,7 +910,6 @@ var EmojiSelection = class EmojiSelection { contents = imports.byteArray.toString(contents); let emoji = JSON.parse(contents); - let pages = []; let variants = []; let currentKey = 0; let currentSection = null; @@ -1406,8 +1402,6 @@ var Keyboard = class Keyboard { } _getDefaultKeysForRow(row, numRows, level) { - let pre, post; - /* The first 2 rows in defaultKeysPre/Post belong together with * the first 2 rows on each keymap. On keymaps that have more than * 4 rows, the last 2 default key rows must be respectively @@ -1646,8 +1640,7 @@ var Keyboard = class Keyboard { } _windowSlideAnimationComplete(window, delta) { - // Synchronize window and actor positions again. - let windowActor = window.get_compositor_private(); + // Synchronize window positions again. let frameRect = window.get_frame_rect(); frameRect.y += delta; window.move_frame(true, frameRect.x, frameRect.y); @@ -1693,7 +1686,6 @@ var Keyboard = class Keyboard { if (window && monitor) { let keyboardHeight = Main.layoutManager.keyboardBox.height; - let focusObscured = false; if (y + h >= monitor.y + monitor.height - keyboardHeight) { if (this._keyboardVisible) @@ -1744,7 +1736,6 @@ var KeyboardController = class { } _onContentPurposeHintsChanged(method) { - let hints = method.content_hints; let purpose = method.content_purpose; let emojiVisible = false; let keypadVisible = false; diff --git a/js/ui/lookingGlass.js b/js/ui/lookingGlass.js index 958211df0..3149cf421 100644 --- a/js/ui/lookingGlass.js +++ b/js/ui/lookingGlass.js @@ -394,7 +394,6 @@ var ObjInspector = class ObjInspector { for (let i = 0; i < properties.length; i++) { let propName = properties[i]; - let valueStr; let link; try { let prop = obj[propName]; @@ -403,7 +402,6 @@ var ObjInspector = class ObjInspector { link = new St.Label({ text: '' }); } let hbox = new St.BoxLayout(); - let propText = propName + ': ' + valueStr; hbox.add(new St.Label({ text: propName + ': ' })); hbox.add(link); this._container.add_actor(hbox); @@ -710,7 +708,6 @@ var Extensions = class Extensions { let metaBox = new St.BoxLayout({ style_class: 'lg-extension-meta' }); box.add(metaBox); - let stateString = this._stateToString(extension.state); let state = new St.Label({ style_class: 'lg-extension-state', text: this._stateToString(extension.state) }); metaBox.add(state); diff --git a/js/ui/magnifier.js b/js/ui/magnifier.js index 289cd1898..fca06e206 100644 --- a/js/ui/magnifier.js +++ b/js/ui/magnifier.js @@ -41,8 +41,6 @@ const CROSS_HAIRS_OPACITY_KEY = 'cross-hairs-opacity'; const CROSS_HAIRS_LENGTH_KEY = 'cross-hairs-length'; const CROSS_HAIRS_CLIP_KEY = 'cross-hairs-clip'; -let magDBusService = null; - var MouseSpriteContent = GObject.registerClass({ Implements: [ Clutter.Content ], }, class MouseSpriteContent extends GObject.Object { @@ -122,7 +120,7 @@ var Magnifier = class Magnifier { }); // Export to dbus. - magDBusService = new MagnifierDBus.ShellMagnifier(); + (new MagnifierDBus.ShellMagnifier()); this.setActive(St.Settings.get().magnifier_active); } @@ -1818,9 +1816,7 @@ var Crosshairs = class Crosshairs { reCenter(clipSize) { let [groupWidth, groupHeight] = this._actor.get_size(); let leftLength = this._horizLeftHair.get_width(); - let rightLength = this._horizRightHair.get_width(); let topLength = this._vertTopHair.get_height(); - let bottomLength = this._vertBottomHair.get_height(); let thickness = this._horizLeftHair.get_height(); // Deal with clip rectangle. diff --git a/js/ui/main.js b/js/ui/main.js index 9b6986001..abd83721c 100644 --- a/js/ui/main.js +++ b/js/ui/main.js @@ -84,7 +84,6 @@ let _cssStylesheet = null; let _a11ySettings = null; let _themeResource = null; let _oskResource = null; -let pointerA11yTimeout = null; function _sessionUpdated() { if (sessionMode.isPrimary) @@ -192,7 +191,7 @@ function _initializeUI() { layoutManager.init(); overview.init(); - pointerA11yTimeout = new PointerA11yTimeout.PointerA11yTimeout(); + (new PointerA11yTimeout.PointerA11yTimeout()); _a11ySettings = new Gio.Settings({ schema_id: A11Y_SCHEMA }); diff --git a/js/ui/osdMonitorLabeler.js b/js/ui/osdMonitorLabeler.js index 62feacede..4c53297b1 100644 --- a/js/ui/osdMonitorLabeler.js +++ b/js/ui/osdMonitorLabeler.js @@ -4,8 +4,6 @@ const { Clutter, Gio, Meta, St } = imports.gi; const Main = imports.ui.main; -var FADE_TIME = 0.1; - var OsdMonitorLabel = class { constructor(monitor, label) { this._actor = new St.Widget({ x_expand: true, diff --git a/js/ui/pointerA11yTimeout.js b/js/ui/pointerA11yTimeout.js index d9309415b..6ec379899 100644 --- a/js/ui/pointerA11yTimeout.js +++ b/js/ui/pointerA11yTimeout.js @@ -3,8 +3,6 @@ const Tweener = imports.ui.tweener; const Main = imports.ui.main; const Cairo = imports.cairo; -const ANIMATION_STEPS = 36.; - var PieTimer = GObject.registerClass( class PieTimer extends St.DrawingArea { _init() { diff --git a/js/ui/runDialog.js b/js/ui/runDialog.js index 8c5cd0792..109bbd91d 100644 --- a/js/ui/runDialog.js +++ b/js/ui/runDialog.js @@ -9,8 +9,6 @@ const Tweener = imports.ui.tweener; const Util = imports.misc.util; const History = imports.misc.history; -var MAX_FILE_DELETED_BEFORE_INVALID = 10; - const HISTORY_KEY = 'command-history'; const LOCKDOWN_SCHEMA = 'org.gnome.desktop.lockdown'; diff --git a/js/ui/screenShield.js b/js/ui/screenShield.js index a005a206b..0c3c00d19 100644 --- a/js/ui/screenShield.js +++ b/js/ui/screenShield.js @@ -44,11 +44,9 @@ var SUMMARY_ICON_SIZE = 48; // - STANDARD_FADE_TIME is used when the session goes idle // - MANUAL_FADE_TIME is used for lowering the shield when asked by the user, // or when cancelling the dialog -// - BACKGROUND_FADE_TIME is used when the background changes to crossfade to new background // - CURTAIN_SLIDE_TIME is used when raising the shield before unlocking var STANDARD_FADE_TIME = 10; var MANUAL_FADE_TIME = 0.3; -var BACKGROUND_FADE_TIME = 1.0; var CURTAIN_SLIDE_TIME = 0.3; var Clock = class { diff --git a/js/ui/slider.js b/js/ui/slider.js index f9fa7320b..3c1b35e05 100644 --- a/js/ui/slider.js +++ b/js/ui/slider.js @@ -42,8 +42,6 @@ var Slider = class extends BarLevel.BarLevel { let [hasHandleColor, handleBorderColor] = themeNode.lookup_color('-slider-handle-border-color', false); - const TAU = Math.PI * 2; - let handleX = handleRadius + (width - 2 * handleRadius) * this._value / this._maxValue; let handleY = height / 2; @@ -185,10 +183,9 @@ var Slider = class extends BarLevel.BarLevel { } _moveHandle(absX, absY) { - let relX, relY, sliderX, sliderY; - [sliderX, sliderY] = this.actor.get_transformed_position(); + let relX, sliderX; + [sliderX] = this.actor.get_transformed_position(); relX = absX - sliderX; - relY = absY - sliderY; let width = this._barLevelWidth; let handleRadius = this.actor.get_theme_node().get_length('-slider-handle-radius'); diff --git a/js/ui/status/volume.js b/js/ui/status/volume.js index cc270500b..8133c3276 100644 --- a/js/ui/status/volume.js +++ b/js/ui/status/volume.js @@ -10,8 +10,6 @@ const Slider = imports.ui.slider; const ALLOW_AMPLIFIED_VOLUME_KEY = 'allow-volume-above-100-percent'; -var VOLUME_NOTIFY_ID = 1; - // Each Gvc.MixerControl is a connection to PulseAudio, // so it's better to make it a singleton let _mixerControl; diff --git a/js/ui/userWidget.js b/js/ui/userWidget.js index a11b34b02..09f74707a 100644 --- a/js/ui/userWidget.js +++ b/js/ui/userWidget.js @@ -2,7 +2,7 @@ // // A widget showing the user avatar and name -const { Clutter, Gio, GLib, GObject, St } = imports.gi; +const { Clutter, GLib, GObject, St } = imports.gi; const Params = imports.misc.params; @@ -44,7 +44,6 @@ var Avatar = class { iconFile = null; if (iconFile) { - let file = Gio.File.new_for_path(iconFile); this.actor.child = null; this.actor.style = ` background-image: url("${iconFile}"); @@ -107,9 +106,6 @@ class UserWidgetLabel extends St.Widget { let [minRealNameWidth, minRealNameHeight, natRealNameWidth, natRealNameHeight] = this._realNameLabel.get_preferred_size(); - let [minUserNameWidth, minUserNameHeight, - natUserNameWidth, natUserNameHeight] = this._userNameLabel.get_preferred_size(); - if (natRealNameWidth <= availWidth) this._currentLabel = this._realNameLabel; else diff --git a/js/ui/viewSelector.js b/js/ui/viewSelector.js index 77146552d..a46cb4cce 100644 --- a/js/ui/viewSelector.js +++ b/js/ui/viewSelector.js @@ -403,7 +403,6 @@ var ViewSelector = class { if (Main.modalCount > 1) return Clutter.EVENT_PROPAGATE; - let modifiers = event.get_state(); let symbol = event.get_key_symbol(); if (symbol == Clutter.Escape) { diff --git a/js/ui/windowManager.js b/js/ui/windowManager.js index d016f3371..a25da9964 100644 --- a/js/ui/windowManager.js +++ b/js/ui/windowManager.js @@ -331,7 +331,6 @@ var WorkspaceTracker = class { if (oldNumWorkspaces == newNumWorkspaces) return false; - let lostWorkspaces = []; if (newNumWorkspaces > oldNumWorkspaces) { let w; diff --git a/js/ui/workspace.js b/js/ui/workspace.js index 1b6c63eb3..16c0e188c 100644 --- a/js/ui/workspace.js +++ b/js/ui/workspace.js @@ -1002,7 +1002,6 @@ var UnalignedLayoutStrategy = class extends LayoutStrategy { let idealRowWidth = totalWidth / numRows; let windowIdx = 0; for (let i = 0; i < numRows; i++) { - let col = 0; let row = this._newRow(); rows.push(row); @@ -1363,7 +1362,6 @@ var Workspace = class { for (let i = 0; i < clones.length; i++) { let clone = clones[i]; - let metaWindow = clone.metaWindow; if (i == 0) { clone.setStackAbove(this._dropRect); } else { diff --git a/js/ui/workspaceThumbnail.js b/js/ui/workspaceThumbnail.js index be196c04b..765f80146 100644 --- a/js/ui/workspaceThumbnail.js +++ b/js/ui/workspaceThumbnail.js @@ -324,7 +324,6 @@ var WorkspaceThumbnail = class { for (let i = 0; i < this._windows.length; i++) { let clone = this._windows[i]; - let metaWindow = clone.metaWindow; if (i == 0) { clone.setStackAbove(this._bgManager.backgroundActor); } else { @@ -914,7 +913,6 @@ class ThumbnailsBox extends St.Widget { let workspaceManager = global.workspace_manager; let oldNumWorkspaces = validThumbnails.length; let newNumWorkspaces = workspaceManager.n_workspaces; - let active = workspaceManager.get_active_workspace_index(); if (newNumWorkspaces > oldNumWorkspaces) { this.addThumbnails(oldNumWorkspaces, newNumWorkspaces - oldNumWorkspaces); @@ -1248,7 +1246,7 @@ class ThumbnailsBox extends St.Widget { if (i == this._dropPlaceholderPos) { let [minHeight, placeholderHeight] = this._dropPlaceholder.get_preferred_height(-1); childBox.x1 = x1; - childBox.x2 = x1 + thumbnailWidth; + childBox.x2 = x2; childBox.y1 = Math.round(y); childBox.y2 = Math.round(y + placeholderHeight); this._dropPlaceholder.allocate(childBox, flags); diff --git a/js/ui/workspacesView.js b/js/ui/workspacesView.js index 78a1c8104..fe16ae8cd 100644 --- a/js/ui/workspacesView.js +++ b/js/ui/workspacesView.js @@ -246,7 +246,6 @@ var WorkspacesView = class extends WorkspacesViewBase { this.scrollAdjustment.upper = newNumWorkspaces; - let needsUpdate = false; for (let j = 0; j < newNumWorkspaces; j++) { let metaWorkspace = workspaceManager.get_workspace_by_index(j); let workspace;