isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "workspacesView: Work around spurious allocation changes"

Browse Source 
We now found the underlying bug: The ControlsManager (which causes the
bad call to `_updateWorkspacesFullGeometry()`) is getting (re-)allocated
while we add the view to the overviewGroup actor because the
overviewGroup is already visible and the view is immediately getting
mapped by `clutter_actor_add_child_internal()`. That causes a
resource-scale calculation and that indirectly causes a call to
`_clutter_stage_maybe_relayout()` (explained more detailed in the last
commit).

So now that we got rid of the immediate relayout happening when mapping
the view, we can revert this fix.

This reverts commit 6cc19ee6f0.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1315
This commit is contained in:
Jonas Dreßler 2020-03-12 13:43:07 +01:00 committed by Florian Müllner
parent 980a90f8fb
commit e4db68a1da
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
js/ui/workspacesView.js
View File

@ -691,15 +691,10 @@ class WorkspacesDisplay extends St.Widget {
else else
view = new WorkspacesView(i, this._scrollAdjustment); view = new WorkspacesView(i, this._scrollAdjustment);
// HACK: Avoid spurious allocation changes while updating views
view.hide();
this._workspacesViews.push(view); this._workspacesViews.push(view);
Main.layoutManager.overviewGroup.add_actor(view); Main.layoutManager.overviewGroup.add_actor(view);
} }
this._workspacesViews.forEach(v => v.show());
if (this._fullGeometry) if (this._fullGeometry)
this._syncWorkspacesFullGeometry(); this._syncWorkspacesFullGeometry();
if (this._actualGeometry) if (this._actualGeometry)