From e48dbe65f10ab6270d254da1c9e40314e73f0842 Mon Sep 17 00:00:00 2001 From: "Jasper St. Pierre" Date: Mon, 10 Dec 2012 03:58:59 -0500 Subject: [PATCH] overview: Clean up overview code The comment here is a liar. We certainly can handle failure using _syncInputMode(). https://bugzilla.gnome.org/show_bug.cgi?id=688589 --- js/ui/overview.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/js/ui/overview.js b/js/ui/overview.js index da4dbae14..7780e8263 100644 --- a/js/ui/overview.js +++ b/js/ui/overview.js @@ -434,12 +434,11 @@ const Overview = new Lang.Class({ return; if (this._shown) return; - // Do this manually instead of using _syncInputMode, to handle failure - if (!Main.pushModal(this._group, { keybindingMode: Main.KeybindingMode.OVERVIEW })) - return; - this._modal = true; - this._animateVisible(); this._shown = true; + this._syncInputMode(); + if (!this._modal) + return; + this._animateVisible(); }, fadeInDesktop: function() {