isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

shell-app: Track all application windows

Browse Source 
Filtering out "non-interesting" windows beforehand as we currently do
means that we may get properties that should be based on all windows,
like the last time the application was used, wrong.
Just track all windows and filter out non-interesting windows manually
in the one place we actually care about the difference.

https://bugzilla.gnome.org/show_bug.cgi?id=719824
This commit is contained in:
Florian Müllner 2013-12-04 17:26:01 +01:00
parent 1e6fff30a3
commit e19faff101
3 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/ui/appDisplay.js
View File

@ -1498,7 +1498,9 @@ const AppIconMenu = new Lang.Class({
_redisplay: function() { _redisplay: function() {
this.removeAll(); this.removeAll();
let windows = this._source.app.get_windows(); let windows = this._source.app.get_windows().filter(function(w) {
return Shell.WindowTracker.is_window_interesting(w);
});
// Display the app windows menu items and the separator between windows // Display the app windows menu items and the separator between windows
// of the current desktop and other windows. // of the current desktop and other windows.

8
src/shell-app.c
View File

@ -739,10 +739,10 @@ shell_app_compare_windows (gconstpointer a,
* shell_app_get_windows: * shell_app_get_windows:
* @app: * @app:
* *
* Get the toplevel, interesting windows which are associated with this * Get the windows which are associated with this application. The
* application. The returned list will be sorted first by whether * returned list will be sorted first by whether they're on the
* they're on the active workspace, then by whether they're visible, * active workspace, then by whether they're visible, and finally
* and finally by the time the user last interacted with them. * by the time the user last interacted with them.
* *
* Returns: (transfer none) (element-type MetaWindow): List of windows * Returns: (transfer none) (element-type MetaWindow): List of windows
*/ */

10
src/shell-window-tracker.c
View File

@ -489,9 +489,6 @@ track_window (ShellWindowTracker *self,
{ {
ShellApp *app; ShellApp *app;
if (!shell_window_tracker_is_window_interesting (window))
return;
app = get_app_for_window (self, window); app = get_app_for_window (self, window);
if (!app) if (!app)
return; return;
@ -530,11 +527,8 @@ disassociate_window (ShellWindowTracker *self,
g_hash_table_remove (self->window_to_app, window); g_hash_table_remove (self->window_to_app, window);
if (shell_window_tracker_is_window_interesting (window)) _shell_app_remove_window (app, window);
{ g_signal_handlers_disconnect_by_func (window, G_CALLBACK(on_wm_class_changed), self);
_shell_app_remove_window (app, window);
g_signal_handlers_disconnect_by_func (window, G_CALLBACK(on_wm_class_changed), self);
}
g_signal_emit (self, signals[TRACKED_WINDOWS_CHANGED], 0); g_signal_emit (self, signals[TRACKED_WINDOWS_CHANGED], 0);