isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

screencastService: Fix 'pipeline' option

Browse Source 
When introducing the pipeline fallback mechanism, support for defining a
custom pipeline was unintentionally dropped, breaking extensions such as
EasyScreenCast.

Fixes 9cb40c4814

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2782>
This commit is contained in:
robert.mader@collabora.com 2023-05-30 20:23:14 +02:00 committed by Marge Bot
parent 4b79eec45a
commit e1145defa9
1 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
js/dbusServices/screencast/screencastService.js
View File

@ -87,6 +87,7 @@ var Recorder = class extends Signals.EventEmitter {
throw e;
}
this._pipelineString = null;
this._framerate = DEFAULT_FRAMERATE;
this._drawCursor = DEFAULT_DRAW_CURSOR;
@ -234,6 +235,23 @@ var Recorder = class extends Signals.EventEmitter {
}
}
*_getPipelineConfigs() {
if (this._pipelineString) {
yield {
pipelineString:
`capsfilter caps=video/x-raw,max-framerate=%F/1 ! ${this._pipelineString}`,
};
return;
}
const fallbackSupported =
Gst.Registry.get().check_feature_version('pipewiresrc', 0, 3, 67);
if (fallbackSupported)
yield* PIPELINES;
else
yield PIPELINES.at(-1);
}
startRecording() {
return new Promise((resolve, reject) => {
this._startRequest = {resolve, reject};
@ -256,10 +274,7 @@ var Recorder = class extends Signals.EventEmitter {
this._nodeId = nodeId;
this._pipelineState = PipelineState.STARTING;
const fallbackSupported =
Gst.Registry.get().check_feature_version('pipewiresrc', 0, 3, 67);
this._pipelineConfigs = fallbackSupported
? PIPELINES.values() : [PIPELINES.at(-1)].values();
this._pipelineConfigs = this._getPipelineConfigs();
this._tryNextPipeline();
});
this._sessionProxy.StartSync();