From dedfdb6d0bc85a17bfee0c710f7989d64176d98f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= <fmuellner@gnome.org> Date: Tue, 27 Apr 2021 21:07:05 +0200 Subject: [PATCH] dbusServices/screensaver: Disable auto-shutdown For the screensaver service, it is quite normal that a consumer only subscribes to the "ActiveChanged" signal without calling any methods. The result is that we don't know about the consumer, and shut down the service anyway after we hit the timeout. If this happens, we break functionality like gnome-settings-daemon's screen blanking on idle. Fix this by simply disabling auto-shutdown for the service, which also reflects the expectation that the screen saver service is always running in a GNOME session. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4114 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1824> --- js/dbusServices/screensaver/screenSaverService.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/js/dbusServices/screensaver/screenSaverService.js b/js/dbusServices/screensaver/screenSaverService.js index 571e64e50..bd3687ef6 100644 --- a/js/dbusServices/screensaver/screenSaverService.js +++ b/js/dbusServices/screensaver/screenSaverService.js @@ -13,6 +13,8 @@ var ScreenSaverService = class extends ServiceImplementation { constructor() { super(ScreenSaverIface, '/org/gnome/ScreenSaver'); + this._autoShutdown = false; + this._proxy = new ScreenSaverProxy(Gio.DBus.session, 'org.gnome.Shell.ScreenShield', '/org/gnome/ScreenSaver',