From dd1651f2d163711d113d3a1b019ef0df86fc030a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20Pi=C3=B1eiro?= Date: Wed, 21 Aug 2013 18:24:30 +0200 Subject: [PATCH] Setting proper name and role for system menu sliders https://bugzilla.gnome.org/show_bug.cgi?id=706391 --- js/ui/slider.js | 4 +++- js/ui/status/brightness.js | 1 + js/ui/status/volume.js | 6 ++++++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/js/ui/slider.js b/js/ui/slider.js index e0e786759..ab90d61d2 100644 --- a/js/ui/slider.js +++ b/js/ui/slider.js @@ -5,6 +5,7 @@ const Clutter = imports.gi.Clutter; const Lang = imports.lang; const St = imports.gi.St; const Signals = imports.signals; +const Atk = imports.gi.Atk; const SLIDER_SCROLL_STEP = 0.05; /* Slider scrolling step in % */ @@ -19,7 +20,8 @@ const Slider = new Lang.Class({ this.actor = new St.DrawingArea({ style_class: 'slider', can_focus: true, - reactive: true }); + reactive: true, + accessible_role: Atk.Role.SLIDER }); this.actor.connect('repaint', Lang.bind(this, this._sliderRepaint)); this.actor.connect('button-press-event', Lang.bind(this, this._startDragging)); this.actor.connect('scroll-event', Lang.bind(this, this._onScrollEvent)); diff --git a/js/ui/status/brightness.js b/js/ui/status/brightness.js index 800a7f28a..bd7697213 100644 --- a/js/ui/status/brightness.js +++ b/js/ui/status/brightness.js @@ -39,6 +39,7 @@ const Indicator = new Lang.Class({ this._slider = new Slider.Slider(0); this._slider.connect('value-changed', Lang.bind(this, this._sliderChanged)); + this._slider.actor.accessible_name = _("Brightness"); let icon = new St.Icon({ icon_name: 'display-brightness-symbolic', style_class: 'popup-menu-icon' }); diff --git a/js/ui/status/volume.js b/js/ui/status/volume.js index b696b1ae4..2b3ac0c6b 100644 --- a/js/ui/status/volume.js +++ b/js/ui/status/volume.js @@ -157,6 +157,11 @@ const OutputStreamSlider = new Lang.Class({ Name: 'OutputStreamSlider', Extends: StreamSlider, + _init: function(control) { + this.parent(control); + this._slider.actor.accessible_name = _("Volume"); + }, + _connectStream: function(stream) { this.parent(stream); this._portChangedId = stream.connect('notify::port', Lang.bind(this, this._portChanged)); @@ -205,6 +210,7 @@ const InputStreamSlider = new Lang.Class({ _init: function(control) { this.parent(control); + this._slider.actor.accessible_name = _("Microphone"); this._control.connect('stream-added', Lang.bind(this, this._maybeShowInput)); this._control.connect('stream-removed', Lang.bind(this, this._maybeShowInput)); this._icon.icon_name = 'audio-input-microphone-symbolic';