isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

panel: Remove drop down arrows from standalone indicators

Browse Source 
The keyboard/language selector area is the smallest element
on the panel. Additional margin about 6px inside the a11y
and language items to make them comfortable to click targets.

With that, we can remove the remaining arrows.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3567

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1583>
This commit is contained in:
Doan Nam Long Vu 2021-01-24 21:39:43 +01:00 committed by Florian Müllner
parent 022cd683c4
commit db9a008e8a
3 changed files with 12 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
data/theme/gnome-shell-sass/widgets/_panel.scss
View File

@ -72,6 +72,12 @@ $panel_transition_duration: 250ms; // same as the overview transition duration
} }
} }
// single indicator
.single-indicator {
margin-left: $base_margin + 3px;
margin-right: $base_margin + 3px;
}
// status area icons // status area icons
.system-status-icon { .system-status-icon {
icon-size: $base_icon_size; icon-size: $base_icon_size;

10
js/ui/status/accessibility.js
View File

@ -34,12 +34,10 @@ class ATIndicator extends PanelMenu.Button {
_init() { _init() {
super._init(0.5, _("Accessibility")); super._init(0.5, _("Accessibility"));
this._hbox = new St.BoxLayout({ style_class: 'panel-status-menu-box' }); this.add_child(new St.Icon({
this._hbox.add_child(new St.Icon({ style_class: 'system-status-icon', style_class: 'single-indicator system-status-icon',
icon_name: 'preferences-desktop-accessibility-symbolic' })); icon_name: 'preferences-desktop-accessibility-symbolic',
this._hbox.add_child(PopupMenu.arrowIcon(St.Side.BOTTOM)); }));
this.add_child(this._hbox);
this._a11ySettings = new Gio.Settings({ schema_id: A11Y_SCHEMA }); this._a11ySettings = new Gio.Settings({ schema_id: A11Y_SCHEMA });
this._a11ySettings.connect('changed::%s'.format(KEY_ALWAYS_SHOW), this._queueSyncMenuVisibility.bind(this)); this._a11ySettings.connect('changed::%s'.format(KEY_ALWAYS_SHOW), this._queueSyncMenuVisibility.bind(this));

9
js/ui/status/keyboard.js
View File

@ -829,13 +829,8 @@ class InputSourceIndicator extends PanelMenu.Button {
this._menuItems = {}; this._menuItems = {};
this._indicatorLabels = {}; this._indicatorLabels = {};
this._container = new InputSourceIndicatorContainer(); this._container = new InputSourceIndicatorContainer({ style_class: 'single-indicator' });
this.add_child(this._container);
this._hbox = new St.BoxLayout({ style_class: 'panel-status-menu-box' });
this._hbox.add_child(this._container);
this._hbox.add_child(PopupMenu.arrowIcon(St.Side.BOTTOM));
this.add_child(this._hbox);
this._propSeparator = new PopupMenu.PopupSeparatorMenuItem(); this._propSeparator = new PopupMenu.PopupSeparatorMenuItem();
this.menu.addMenuItem(this._propSeparator); this.menu.addMenuItem(this._propSeparator);