isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

status/network: Some minor style fixes

Browse Source 
I wasn't genuiously going to touch those lines, but I ran into
a limitation of the run-eslint script:

It currently bases changed lines on a diff between HEAD and main
instead of the commit-by-commit log.

The two can vary quite a bit when shuffling code around, and those
are the lines the tool kept complaining about.

I'll look into improving the script, but for now it's quicker to
just shut it up by fixing up the complaints.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2406>
This commit is contained in:
Florian Müllner 2022-08-07 22:09:23 +02:00
parent 3567a545b3
commit d9d70c162d
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
js/ui/status/network.js
View File

@ -410,7 +410,7 @@ var NMConnectionDevice = class NMConnectionDevice extends NMConnectionSection {
_sync() { _sync() {
let nItems = this._connectionItems.size; let nItems = this._connectionItems.size;
this._autoConnectItem.visible = nItems == 0; this._autoConnectItem.visible = nItems === 0;
this._deactivateItem.visible = this._device.state > NM.DeviceState.DISCONNECTED; this._deactivateItem.visible = this._device.state > NM.DeviceState.DISCONNECTED;
if (this._activeConnection == null) { if (this._activeConnection == null) {
@ -1392,10 +1392,10 @@ var NMDeviceWireless = class extends Signals.EventEmitter {
} }
_canReachInternet() { _canReachInternet() {
if (this._client.primary_connection != this._device.active_connection) if (this._client.primary_connection !== this._device.active_connection)
return true; return true;
return this._client.connectivity == NM.ConnectivityState.FULL; return this._client.connectivity === NM.ConnectivityState.FULL;
} }
_isHotSpotMaster() { _isHotSpotMaster() {
@ -1410,7 +1410,7 @@ var NMDeviceWireless = class extends Signals.EventEmitter {
if (!ip4config) if (!ip4config)
return false; return false;
return ip4config.get_method() == NM.SETTING_IP4_CONFIG_METHOD_SHARED; return ip4config.get_method() === NM.SETTING_IP4_CONFIG_METHOD_SHARED;
} }
getIndicatorIcon() { getIndicatorIcon() {
@ -1995,8 +1995,8 @@ class Indicator extends PanelMenu.SystemIndicator {
} }
_mainConnectionStateChanged() { _mainConnectionStateChanged() {
if (this._mainConnection.state == NM.ActiveConnectionState.ACTIVATED && this._notification) if (this._mainConnection.state === NM.ActiveConnectionState.ACTIVATED)
this._notification.destroy(); this._notification?.destroy();
} }
_ignoreConnection(connection) { _ignoreConnection(connection) {