From d7ff7e062bf846ff9cd0f628bb1d976f745427b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Wed, 11 Mar 2015 17:25:25 +0100 Subject: [PATCH] messageTray: Always destroy banners when done displaying Special-casing banners of resident notifications was really a thinly veiled special case for chat notifications, as those were still using the old notification actor which coupled the life-time of the notification to its actor. This is no longer the case, so we can do the sane thing and destroy banners once they are no longer needed. --- js/ui/messageTray.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js index 4d7d93518..b69492b05 100644 --- a/js/ui/messageTray.js +++ b/js/ui/messageTray.js @@ -2091,10 +2091,7 @@ const MessageTray = new Lang.Class({ this._pointerInNotification = false; this._notificationRemoved = false; - if (notification.resident) - this._bannerBin.remove_actor(this._banner.actor); - else - this._banner.actor.destroy(); + this._banner.actor.destroy(); this._banner = null; this.actor.hide(); },