From d62391c8f129b9b9808d6e51cc690004819b0496 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Wed, 19 Feb 2020 18:06:38 +0100 Subject: [PATCH] unlockDialog: Set accessible name of icon-only buttons We turned both the auth prompt's cancel button and the switch user button into icon buttons now, which means they are completely cryptic when using a screen reader. Just use the previously used labels as accessible names, which has the nice side effect of lowering the impact of the string freeze break. https://gitlab.gnome.org/GNOME/gnome-shell/issues/2210 --- js/gdm/authPrompt.js | 1 + js/ui/unlockDialog.js | 1 + 2 files changed, 2 insertions(+) diff --git a/js/gdm/authPrompt.js b/js/gdm/authPrompt.js index bab6d5dee..4bcd028ae 100644 --- a/js/gdm/authPrompt.js +++ b/js/gdm/authPrompt.js @@ -132,6 +132,7 @@ var AuthPrompt = GObject.registerClass({ this.cancelButton = new St.Button({ style_class: 'modal-dialog-button button cancel-button', + accessible_name: _('Cancel'), button_mask: St.ButtonMask.ONE | St.ButtonMask.THREE, reactive: this._hasCancelButton, can_focus: this._hasCancelButton, diff --git a/js/ui/unlockDialog.js b/js/ui/unlockDialog.js index f894709ff..14bd972d6 100644 --- a/js/ui/unlockDialog.js +++ b/js/ui/unlockDialog.js @@ -555,6 +555,7 @@ var UnlockDialog = GObject.registerClass({ // Switch User button this._otherUserButton = new St.Button({ style_class: 'modal-dialog-button button switch-user-button', + accessible_name: _('Log in as another user'), can_focus: true, reactive: true, x_align: Clutter.ActorAlign.END,