From d52b1576ac16266a7b84c7fa5061a4a11da2ab96 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Mon, 1 Aug 2022 11:26:59 +0200 Subject: [PATCH] main: Replace custom log function with console console.log() is implemented with structured logging, and as we set an appropriate log domain, it's identical to the custom function bar the custom fields with extension data. Few people know about those custom fields, and adding them comes at a cost, as we end up producing and parsing a stacktrace on every log() call. It therefore seems appropriate to drop the custom function, and turn the global log() symbol into a simple convenience alias for console.log(). If it turns out that people do miss the custom fields, we can add an alternative to ExtensionUtils. Part-of: --- js/ui/main.js | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/js/ui/main.js b/js/ui/main.js index e1cc25afa..34a3b0e78 100644 --- a/js/ui/main.js +++ b/js/ui/main.js @@ -147,27 +147,9 @@ function _sessionUpdated() { } } -/** - * @param {any...} args a list of values to log - */ -function _loggingFunc(...args) { - let fields = { 'MESSAGE': args.join(', ') }; - let domain = 'GNOME Shell'; - - // If the caller is an extension, add it as metadata - let extension = imports.misc.extensionUtils.getCurrentExtension(); - if (extension != null) { - domain = extension.metadata.name; - fields['GNOME_SHELL_EXTENSION_UUID'] = extension.uuid; - fields['GNOME_SHELL_EXTENSION_NAME'] = extension.metadata.name; - } - - GLib.log_structured(domain, GLib.LogLevelFlags.LEVEL_MESSAGE, fields); -} - /** @returns {void} */ async function start() { - globalThis.log = _loggingFunc; + globalThis.log = console.log; // Chain up async errors reported from C global.connect('notify-error', (global, msg, detail) => {