From d1cbf6c7a94472aa5f7f300e3e29f6028adb8c45 Mon Sep 17 00:00:00 2001 From: Georges Basile Stavracas Neto Date: Wed, 27 May 2020 15:49:29 -0300 Subject: [PATCH] appDisplay: Allow overshooting any icon Now that the icon being dragged can come from AppDisplay and also a folder dialog, the check for when to overshoot is broken. Check if the icon is a BaseAppView icon. https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1284 --- js/ui/appDisplay.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js index 65d41fa53..5c5e70c98 100644 --- a/js/ui/appDisplay.js +++ b/js/ui/appDisplay.js @@ -1056,7 +1056,7 @@ class AppDisplay extends BaseAppView { // Handle the drag overshoot. When dragging to above the // icon grid, move to the page above; when dragging below, // move to the page below. - if (this._grid.contains(appIcon)) + if (appIcon instanceof AppViewItem) this._handleDragOvershoot(dragEvent); this._maybeMoveItem(dragEvent);