From d04d6e069df16867779f50ca239c7f51a045bc77 Mon Sep 17 00:00:00 2001 From: Georges Basile Stavracas Neto Date: Thu, 16 Jul 2020 11:15:03 -0300 Subject: [PATCH] appDisplay: Check 'app-picker-layout' to make icons draggable Now we drag not only to the Dash, but also to the icon grid itself, so make the app icon draggable only when either one or the other is writable. https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1284 --- js/ui/appDisplay.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js index a2ae129a4..dde351be2 100644 --- a/js/ui/appDisplay.js +++ b/js/ui/appDisplay.js @@ -843,7 +843,9 @@ class AppDisplay extends BaseAppView { // at least on single-monitor setups. // This also disables drag-to-launch on multi-monitor setups, // but we hope that is not used much. - let favoritesWritable = global.settings.is_writable('favorite-apps'); + const isDraggable = + global.settings.is_writable('favorite-apps') || + global.settings.is_writable('app-picker-layout'); apps.forEach(appId => { if (appsInsideFolders.has(appId)) @@ -853,9 +855,7 @@ class AppDisplay extends BaseAppView { if (!icon) { let app = appSys.lookup_app(appId); - icon = new AppIcon(app, { - isDraggable: favoritesWritable, - }); + icon = new AppIcon(app, { isDraggable }); } appIcons.push(icon);