isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

appDisplay: use ShellAppCache to access GAppInfo

Browse Source 
Calls to Gio.AppInfo.get_all() can perform quite a bit of I/O on the
calling thread. This can potentially stall the compositor if the disk
controller is saturated.

Instead we can call the new ShellAppCache which contains cached information
and performs all update I/O on a thread.

Notifications of changes work very similar to GAppInfoMonitor via the
ShellAppCache::changed() signal.
This commit is contained in:
Christian Hergert 2020-02-26 23:11:33 -08:00
parent f87b9f374a
commit cfb92ad392
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/ui/appDisplay.js
View File

@ -491,7 +491,7 @@ var AllView = new Lang.Class({
}, },
_loadApps() { _loadApps() {
let apps = Gio.AppInfo.get_all().filter(appInfo => { let apps = Shell.AppCache.get_default().get_all().filter(appInfo => {
try { try {
let id = appInfo.get_id(); // catch invalid file encodings let id = appInfo.get_id(); // catch invalid file encodings
} catch(e) { } catch(e) {
@ -1321,7 +1321,7 @@ var FolderIcon = new Lang.Class({
folderApps.forEach(addAppId); folderApps.forEach(addAppId);
let folderCategories = this._folder.get_strv('categories'); let folderCategories = this._folder.get_strv('categories');
Gio.AppInfo.get_all().forEach(appInfo => { Shell.AppCache.get_default().get_all().forEach(appInfo => {
let appCategories = _getCategories(appInfo); let appCategories = _getCategories(appInfo);
if (!_listsIntersect(folderCategories, appCategories)) if (!_listsIntersect(folderCategories, appCategories))
return; return;