isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

runDialog: Don’t add empty input to history

Browse Source 
If the input is empty, there’s no point in adding it to the history –
it’ll just be mildly annoying when the user has to skip past it next
time they consult the history.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3183.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1442>
This commit is contained in:
Lucas Werkmeister 2021-02-07 19:38:40 +01:00 committed by Marge Bot
parent 7bea63ae4b
commit cb26a636e8
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
js/ui/runDialog.js
View File

@ -180,7 +180,8 @@ class RunDialog extends ModalDialog.ModalDialog {
_run(input, inTerminal) { _run(input, inTerminal) {
let command = input; let command = input;
this._history.addItem(input); if (input)
this._history.addItem(input);
this._commandError = false; this._commandError = false;
let f; let f;
if (this._enableInternalCommands) if (this._enableInternalCommands)