From c627d47019b0319c47e99c2ed8cd014b9bf98d62 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Dre=C3=9Fler?= Date: Sun, 23 Jun 2019 12:15:12 +0200 Subject: [PATCH] polkitAgent: Also show user avatar for root user Show the user avatar for all users, including the root user. The root user will always have the generic avatar, but it looks more consistent than showing no avatar at all. This way we also don't have to worry about the spacing introduced by the polkit-dialog-user-layout CSS class, which would give the "Administrator" label a small offset to the left. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/788 --- js/ui/components/polkitAgent.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/js/ui/components/polkitAgent.js b/js/ui/components/polkitAgent.js index 6c519a647..30d04d5c5 100644 --- a/js/ui/components/polkitAgent.js +++ b/js/ui/components/polkitAgent.js @@ -62,7 +62,6 @@ var AuthenticationDialog = GObject.registerClass({ iconSize: DIALOG_ICON_SIZE, styleClass: 'polkit-dialog-user-icon', }); - this._userAvatar.hide(); userBox.add_child(this._userAvatar); this._userLabel = new St.Label({ @@ -305,12 +304,10 @@ var AuthenticationDialog = GObject.registerClass({ let userName = this._user.get_user_name(); let realName = this._user.get_real_name(); - if (userName !== 'root') { + if (userName !== 'root') this._userLabel.set_text(realName); - this._userAvatar.update(); - this._userAvatar.show(); - } + this._userAvatar.update(); } cancel() {