From c5dfc432d90c88a3d67e3e702a497329203d0baa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Thu, 4 Jul 2013 02:57:32 +0200 Subject: [PATCH] checkBox: Remove height-for-width hack With the move to ClutterBoxLayout, height-for-width should now work properly, so remove this old hack. https://bugzilla.gnome.org/show_bug.cgi?id=703811 --- js/ui/checkBox.js | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/js/ui/checkBox.js b/js/ui/checkBox.js index 06b4367ee..097fe96f6 100644 --- a/js/ui/checkBox.js +++ b/js/ui/checkBox.js @@ -42,12 +42,6 @@ const CheckBoxContainer = new Lang.Class({ }, _getPreferredHeight: function(actor, forWidth, alloc) { - /* FIXME: StBoxlayout currently does not handle - height-for-width children correctly, so hard-code - two lines for the label until that problem is fixed. - - https://bugzilla.gnome.org/show_bug.cgi?id=672543 */ -/* let [minBoxHeight, natBoxHeight] = this._box.get_preferred_height(forWidth); let [minLabelHeight, natLabelHeight] = @@ -55,14 +49,6 @@ const CheckBoxContainer = new Lang.Class({ alloc.min_size = Math.max(minBoxHeight, minLabelHeight); alloc.natural_size = Math.max(natBoxHeight, natLabelHeight); -*/ - let [minBoxHeight, natBoxHeight] = - this._box.get_preferred_height(-1); - let [minLabelHeight, natLabelHeight] = - this.label.get_preferred_height(-1); - - alloc.min_size = Math.max(minBoxHeight, 2 * minLabelHeight); - alloc.natural_size = Math.max(natBoxHeight, 2 * natLabelHeight); }, _allocate: function(actor, box, flags) {