isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

screenShield: Align notifications to the left, not the middle

Browse Source 
With different lengths of text in notifications, icons aren't
aligned and things look ugly. Put notifications on the left
for now.

https://bugzilla.gnome.org/show_bug.cgi?id=685919
This commit is contained in:
Jasper St. Pierre 2012-10-10 18:07:39 -03:00
parent 3fdc8bfa3d
commit b3cd46a5c8
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
js/ui/screenShield.js
View File

@ -95,13 +95,13 @@ const NotificationsBox = new Lang.Class({
this._residentNotificationBox = new St.BoxLayout({ vertical: true, this._residentNotificationBox = new St.BoxLayout({ vertical: true,
style_class: 'screen-shield-notifications-box' }); style_class: 'screen-shield-notifications-box' });
let scrollView = new St.ScrollView({ x_fill: false, x_align: St.Align.MIDDLE }); let scrollView = new St.ScrollView({ x_fill: false, x_align: St.Align.START });
this._persistentNotificationBox = new St.BoxLayout({ vertical: true, this._persistentNotificationBox = new St.BoxLayout({ vertical: true,
style_class: 'screen-shield-notifications-box' }); style_class: 'screen-shield-notifications-box' });
scrollView.add_actor(this._persistentNotificationBox); scrollView.add_actor(this._persistentNotificationBox);
this.actor.add(this._residentNotificationBox, { x_fill: true }); this.actor.add(this._residentNotificationBox, { x_fill: true });
this.actor.add(scrollView, { x_fill: true, x_align: St.Align.MIDDLE }); this.actor.add(scrollView, { x_fill: true, x_align: St.Align.START });
this._items = []; this._items = [];
Main.messageTray.getSummaryItems().forEach(Lang.bind(this, function(item) { Main.messageTray.getSummaryItems().forEach(Lang.bind(this, function(item) {
@ -153,7 +153,7 @@ const NotificationsBox = new Lang.Class({
box.add(sourceActor.actor, { y_fill: true }); box.add(sourceActor.actor, { y_fill: true });
let textBox = new St.BoxLayout({ vertical: true }); let textBox = new St.BoxLayout({ vertical: true });
box.add(textBox); box.add(textBox, { y_fill: false, y_align: St.Align.START });
let label = new St.Label({ text: source.title, let label = new St.Label({ text: source.title,
style_class: 'screen-shield-notification-label' }); style_class: 'screen-shield-notification-label' });
@ -190,7 +190,7 @@ const NotificationsBox = new Lang.Class({
item.prepareNotificationStackForShowing(); item.prepareNotificationStackForShowing();
} else { } else {
[obj.sourceBox, obj.countLabel] = this._makeNotificationSource(item.source); [obj.sourceBox, obj.countLabel] = this._makeNotificationSource(item.source);
this._persistentNotificationBox.add(obj.sourceBox, { x_fill: false, x_align: St.Align.MIDDLE }); this._persistentNotificationBox.add(obj.sourceBox, { x_fill: false, x_align: St.Align.START });
} }
obj.contentUpdatedId = item.connect('content-updated', Lang.bind(this, this._onItemContentUpdated)); obj.contentUpdatedId = item.connect('content-updated', Lang.bind(this, this._onItemContentUpdated));
@ -236,7 +236,7 @@ const NotificationsBox = new Lang.Class({
this._residentNotificationBox.remove_actor(obj.item.notificationStackWidget); this._residentNotificationBox.remove_actor(obj.item.notificationStackWidget);
[obj.sourceBox, obj.countLabel] = this._makeNotificationSource(obj.source); [obj.sourceBox, obj.countLabel] = this._makeNotificationSource(obj.source);
this._persistentNotificationBox.add(obj.sourceBox); this._persistentNotificationBox.add(obj.sourceBox, { x_fill: false, x_align: St.Align.START });
} else if (itemShouldBeResident && !obj.resident) { } else if (itemShouldBeResident && !obj.resident) {
// make into a resident item // make into a resident item
obj.sourceBox.destroy(); obj.sourceBox.destroy();