From b2b685e46d489f101b94f1ad23c0794804c274fc Mon Sep 17 00:00:00 2001 From: Giovanni Campagna Date: Tue, 29 Mar 2011 14:29:26 +0200 Subject: [PATCH] NetworkMenu: fixup device descriptions Fix some bugs in Util.fixupPCIDescription(), that caused all device descriptions to be empty. https://bugzilla.gnome.org/show_bug.cgi?id=646074 --- js/misc/util.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/js/misc/util.js b/js/misc/util.js index e22811716..2d9cef264 100644 --- a/js/misc/util.js +++ b/js/misc/util.js @@ -150,7 +150,7 @@ const _IGNORED_WORDS = [ 'Incorporated', 'Ltd.', 'Limited.', - 'Intel?', + 'Intel', 'chipset', 'adapter', '[hex]', @@ -181,7 +181,7 @@ const _IGNORED_PHRASES = [ ]; function fixupPCIDescription(desc) { - desc.replace(/[_,]/, ' '); + desc = desc.replace(/[_,]/, ' '); /* Attempt to shorten ID by ignoring certain phrases */ for (let i = 0; i < _IGNORED_PHRASES.length; i++) { @@ -197,7 +197,7 @@ function fixupPCIDescription(desc) { /* Attmept to shorten ID by ignoring certain individual words */ let words = desc.split(' '); let out = [ ]; - for (let i = 0; i < words; i++) { + for (let i = 0; i < words.length; i++) { let item = words[i]; // skip empty items (that come out from consecutive spaces)