From afc7925e3e03282e4dfd050bc67c36490629a5de Mon Sep 17 00:00:00 2001 From: Ray Strode Date: Fri, 31 Aug 2018 12:48:00 -0400 Subject: [PATCH] objectManager: correct invalid index code in onNameVanished The object manager tries to synthesize interface removal events if the bus name of a remote object drops off the bus. The code has a bad typo in it, though: it confuses `objectPaths` (the list of all object paths) and `objectPath` (the object currently being processed this iteration of the loop). That leads to a failure to synthesize the interface removal events, and spew in the log. This commit corrects the objectPath/objectPaths confusion. --- js/misc/objectManager.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/js/misc/objectManager.js b/js/misc/objectManager.js index efe669ba3..134887491 100644 --- a/js/misc/objectManager.js +++ b/js/misc/objectManager.js @@ -237,7 +237,8 @@ var ObjectManager = new Lang.Class({ _onNameVanished() { let objectPaths = Object.keys(this._objects); for (let i = 0; i < objectPaths.length; i++) { - let object = this._objects[objectPaths]; + let objectPath = objectPaths[i]; + let object = this._objects[objectPath]; let interfaceNames = Object.keys(object); for (let j = 0; i < interfaceNames.length; i++) {