isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cleanup: Minimize deep_unpack() usage

Browse Source 
deep_unpack()[1] will unpack a variant and its children, but only up to one level.
lookup_value()[2] will directly search for a value with a linear scan.

Performing a deep_unpack() + lookup can be a more expensive operation when we are
looking for just a single value compared to just perform the lookup_value() directly
in C. Avoid the deep_unpack() usage when we perform a single check presence.

[1] https://gjs.guide/guides/glib/gvariant.html#deepunpack
[2] https://docs.gtk.org/glib/method.Variant.lookup_value.html

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2416>
This commit is contained in:
Alessandro Bono
2022-08-10 11:44:42 +02:00
committed by Marge Bot
parent 23bfd08b3c
commit ade4b23796
7 changed files with 23 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
js/ui/status/thunderbolt.js
View File

@ -83,12 +83,11 @@ var Client = class extends Signals.EventEmitter {
}
_onPropertiesChanged(proxy, properties) {
let unpacked = properties.deep_unpack();
if (!('Probing' in unpacked))
return;
this.probing = this._proxy.Probing;
this.emit('probing-changed', this.probing);
const probingChanged = !!properties.lookup_value('Probing', null);
if (probingChanged) {
this.probing = this._proxy.Probing;
this.emit('probing-changed', this.probing);
}
}
_onDeviceAdded(proxy, emitter, params) {