isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

dash: Do not shadow ClutterActor's destroy()

Browse Source 
Since commit ef1e27966d turned DashItemContainer into an StWidget,
the destroy() method overrides the ClutterActor method, which is at
the very least bad style. Instead, follow the usual pattern of using
a ::destroy handler.

https://bugzilla.gnome.org/show_bug.cgi?id=791233
This commit is contained in:
Marco Trevisan (Treviño)
2017-12-05 17:04:24 -05:00
parent d5805f9f0d
commit ac596ca1c1
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
js/ui/dash.js
View File

@ -50,6 +50,10 @@ var DashItemContainer = new Lang.Class({
this._childScale = 0; this._childScale = 0;
this._childOpacity = 0; this._childOpacity = 0;
this.animatingOut = false; this.animatingOut = false;
this.connect('destroy', () => {
this.label.destroy();
});
}, },
vfunc_allocate: function(box, flags) { vfunc_allocate: function(box, flags) {
@ -177,11 +181,6 @@ var DashItemContainer = new Lang.Class({
}); });
}, },
destroy: function() {
this.label.destroy();
this.parent();
},
animateOutAndDestroy: function() { animateOutAndDestroy: function() {
this.label.hide(); this.label.hide();