From a67877f5201c7f5b168329c3758adee3f90ba575 Mon Sep 17 00:00:00 2001 From: Rachit Keerti Das Date: Sat, 29 Jan 2022 22:37:25 +0530 Subject: [PATCH] dash: Use pin instead of favorites Use the term 'pin' for adding new items to the dash Note that this is only a string change. Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4976 Part-of: --- js/ui/appFavorites.js | 4 ++-- js/ui/appMenu.js | 4 ++-- js/ui/dash.js | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/js/ui/appFavorites.js b/js/ui/appFavorites.js index a876727ed..4e372c213 100644 --- a/js/ui/appFavorites.js +++ b/js/ui/appFavorites.js @@ -161,7 +161,7 @@ class AppFavorites { let app = Shell.AppSystem.get_default().lookup_app(appId); - let msg = _("%s has been added to your favorites.").format(app.get_name()); + let msg = _('%s has been pinned to the dash.').format(app.get_name()); Main.overview.setMessage(msg, { forFeedback: true, undoCallback: () => this._removeFavorite(appId), @@ -194,7 +194,7 @@ class AppFavorites { if (!this._removeFavorite(appId)) return; - let msg = _("%s has been removed from your favorites.").format(app.get_name()); + let msg = _('%s has been unpinned from the dash.').format(app.get_name()); Main.overview.setMessage(msg, { forFeedback: true, undoCallback: () => this._addFavorite(appId, pos), diff --git a/js/ui/appMenu.js b/js/ui/appMenu.js index 87d2218cd..671f223f3 100644 --- a/js/ui/appMenu.js +++ b/js/ui/appMenu.js @@ -160,8 +160,8 @@ var AppMenu = class AppMenu extends PopupMenu.PopupMenu { const { id } = this._app; this._toggleFavoriteItem.label.text = this._appFavorites.isFavorite(id) - ? _('Remove from Favorites') - : _('Add to Favorites'); + ? _('Unpin') + : _('Pin to Dash'); } _updateGpuItem() { diff --git a/js/ui/dash.js b/js/ui/dash.js index 08902c436..311117471 100644 --- a/js/ui/dash.js +++ b/js/ui/dash.js @@ -242,7 +242,7 @@ class ShowAppsIcon extends DashItemContainer { this._iconActor.set_hover(canRemove); if (canRemove) - this.setLabelText(_("Remove from Favorites")); + this.setLabelText(_('Unpin')); else this.setLabelText(_("Show Applications")); }