From a3bfe0ab560ed214c888b79daca89975fed9604e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Dre=C3=9Fler?= Date: Thu, 26 May 2022 18:13:12 +0200 Subject: [PATCH] keyboard: Reset height before requesting preferred height If we don't set the height property to -1 before requesting the preferred height, get_preferred_height() will just return us the fixed height that has been set before. We don't want this behavior here, so set the height to -1 before calling get_preferred_height(). This fixes a resizing issue where the keyboard is sized incorrectly after switching the monitor into portrait mode and back. Part-of: --- js/ui/keyboard.js | 1 + 1 file changed, 1 insertion(+) diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js index e0c42219e..b9e3aec60 100644 --- a/js/ui/keyboard.js +++ b/js/ui/keyboard.js @@ -1697,6 +1697,7 @@ var Keyboard = GObject.registerClass({ * we allow the OSK being smaller than 1/3rd of the monitor height * there. */ + this.height = -1; const forWidth = this.get_theme_node().adjust_for_width(monitor.width); const [, natHeight] = this.get_preferred_height(forWidth); this.height = Math.min(maxHeight, natHeight);