From a029a3505039de17e0b4fa7593e825a079d115a9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Wed, 14 Sep 2016 22:44:12 +0200 Subject: [PATCH] altTab: Improve cycling to a window on another workspace Both 'cycle-group' and 'cycle-window' shortcuts allow cycling through windows on all workspaces. While this works, it looks quite broken since we started showing clones for highlighting: the selected window vanishes (when its clone is destroyed), then slides back in with its workspace. Instead, slide the selected window to its workspace like we do for the 'move-to-workspace-*' shortcuts. https://bugzilla.gnome.org/show_bug.cgi?id=771536 --- js/ui/altTab.js | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/js/ui/altTab.js b/js/ui/altTab.js index c2217075b..27aa2d7bf 100644 --- a/js/ui/altTab.js +++ b/js/ui/altTab.js @@ -444,7 +444,21 @@ const CyclerPopup = new Lang.Class({ }, _finish: function() { - Main.activateWindow(this._items[this._selectedIndex]); + let window = this._items[this._selectedIndex]; + let ws = window.get_workspace(); + let activeWs = global.screen.get_active_workspace(); + + if (activeWs == ws) { + Main.activateWindow(window); + } else { + // If the selected window is on a different workspace, we don't + // want it to disappear, then slide in with the workspace; instead, + // always activate it on the active workspace ... + activeWs.activate_with_focus(window, global.get_current_time()); + + // ... then slide it over to the original workspace if necessary + Main.wm.actionMoveWindow(window, ws); + } this.parent(); },