From 9f968e7378543e4377e723fb579ded62d534d5dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20=C3=85dahl?= Date: Tue, 31 Mar 2020 17:00:58 +0000 Subject: [PATCH] appDisplay: Clear animateLater callbacks when unmapping In some situations we could end up not with lingering 'view-loaded' handler. This could result in delayed spring animate-in being initiated, e.g. after a minute after the activities overview was already closed. Fix this by removing any lingering signal or later handlers when unmapping. Fixes: 5c33fe4a0a4eb4ed https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1155 (cherry picked from commit f49b58cf97e167dca74b902fe1bf21d296495113) --- js/ui/appDisplay.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js index 2d57a6df2..98aa12105 100644 --- a/js/ui/appDisplay.js +++ b/js/ui/appDisplay.js @@ -291,6 +291,11 @@ var BaseAppView = GObject.registerClass({ } } + vfunc_unmap() { + this._clearAnimateLater(); + super.vfunc_unmap(); + } + animateSwitch(animationDirection) { this.remove_all_transitions(); this._grid.remove_all_transitions();