From 9c9da8a1762d515d739c9ba1923dde9e24378373 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Sun, 15 Feb 2015 20:19:03 +0100 Subject: [PATCH] messageTray: Remove _lastNotificationRemoved() No Source subclass used it to do anything special, and with sources no longer having any UI representation on their own, doing anything else isn't useful either, so just kill off that hook. https://bugzilla.gnome.org/show_bug.cgi?id=744850 --- js/ui/messageTray.js | 7 +------ js/ui/notificationDaemon.js | 4 ---- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js index 4baed6a79..4bf25805e 100644 --- a/js/ui/messageTray.js +++ b/js/ui/messageTray.js @@ -1304,7 +1304,7 @@ const Source = new Lang.Class({ this.notifications.splice(index, 1); if (this.notifications.length == 0) - this._lastNotificationRemoved(); + this.destroy(); this.countUpdated(); }, @@ -1357,11 +1357,6 @@ const Source = new Lang.Class({ this.notifications[i].destroy(); this.countUpdated(); - }, - - // Default implementation is to destroy this source, but subclasses can override - _lastNotificationRemoved: function() { - this.destroy(); } }); Signals.addSignalMethods(Source.prototype); diff --git a/js/ui/notificationDaemon.js b/js/ui/notificationDaemon.js index aedda638f..8d470c9cf 100644 --- a/js/ui/notificationDaemon.js +++ b/js/ui/notificationDaemon.js @@ -551,10 +551,6 @@ const FdoNotificationDaemonSource = new Lang.Class({ this.destroyNonResidentNotifications(); }, - _lastNotificationRemoved: function() { - this.destroy(); - }, - openApp: function() { if (this.app == null) return;