From 9b24d9c4c0c08f258636d6d3388ea573336fcb9d Mon Sep 17 00:00:00 2001 From: Carlos Garnacho Date: Tue, 23 Feb 2021 23:39:29 +0100 Subject: [PATCH] appDisplay: Don't reset adjustment on ::pages-changed Let the goToPage call afterwards to take precedence, instead of resetting the adjustment (thus the view) on the side. This resulted in strange state when the last page contains a single icon, and it is dragged. The last page being emptied triggers a pages-changed signal, which half resets the view to the first page while DnD is ongoing. Letting goToPage do its business means we neatly clamp to the closest page to currentPage, the last page in that case. Part-of: --- js/ui/appDisplay.js | 1 - 1 file changed, 1 deletion(-) diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js index 94d1ef24e..0c2b97598 100644 --- a/js/ui/appDisplay.js +++ b/js/ui/appDisplay.js @@ -143,7 +143,6 @@ var BaseAppView = GObject.registerClass({ // Standard hack for ClutterBinLayout this._grid.x_expand = true; this._grid.connect('pages-changed', () => { - this._adjustment.value = 0; this.goToPage(this._grid.currentPage); this._pageIndicators.setNPages(this._grid.nPages); this._pageIndicators.setCurrentPosition(this._grid.currentPage);