From 9491f6bd23f2752e67f98a6ad1577272c8fcfb60 Mon Sep 17 00:00:00 2001 From: Tanner Doshier Date: Thu, 16 Aug 2012 19:59:33 -0500 Subject: [PATCH] dash: fix for shrinking dash while animating The this.actor.height > this._maxHeight check is needed because animating the dash out causes constant notify::height signals and so after each one the max height would shrink to the actor height causing the icons to shrink until eventually we get to 16px icons. This way, only increase maxHeight if the actor can be drawn bigger than it is currently set. https://bugzilla.gnome.org/show_bug.cgi?id=682050 --- js/ui/dash.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/js/ui/dash.js b/js/ui/dash.js index ada34606c..1c4a76747 100644 --- a/js/ui/dash.js +++ b/js/ui/dash.js @@ -402,7 +402,8 @@ const Dash = new Lang.Class({ function() { if (this._maxHeight != this.actor.height) this._queueRedisplay(); - this._maxHeight = this.actor.height; + if (this.actor.height > this._maxHeight) + this._maxHeight = this.actor.height; })); this._workId = Main.initializeDeferredWork(this._box, Lang.bind(this, this._redisplay));