isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

appDisplay: Don't crash if app is missing categories

Browse Source 
g_desktop_app_info_get_categories() may return null. In that case, the
previous code would fail to create a folder when dragging an app with
no categories onto another app. Instead, simply continue with the next
app info.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/782
This commit is contained in:
Philip Chimento 2019-10-25 15:27:25 -07:00 committed by Florian Müllner
parent 03219f745d
commit 8d2365b7b9
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
js/ui/appDisplay.js
View File

@ -97,7 +97,10 @@ function _findBestFolderName(apps) {
let commonCategories = []; let commonCategories = [];
appInfos.reduce((categories, appInfo) => { appInfos.reduce((categories, appInfo) => {
for (let category of appInfo.get_categories().split(';')) { const appCategories = appInfo.get_categories();
if (!appCategories)
return categories;
for (let category of appCategories.split(';')) {
if (!(category in categoryCounter)) if (!(category in categoryCounter))
categoryCounter[category] = 0; categoryCounter[category] = 0;