isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

extensions-tool/create: Add --gettext-domain flag

Browse Source 
Our convenience API considers a `gettext-domain` field in the
metadata, so it makes sense for `gnome-extensions create` to
allow setting it.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2889>
This commit is contained in:
Florian Müllner 2023-08-13 23:46:33 +02:00 committed by Marge Bot
parent 6e47ca53b0
commit 8b9d8d7bb8
2 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
subprojects/extensions-tool/man/gnome-extensions.txt
View File

@ -128,6 +128,9 @@ Creates a new extension from a template.
*--uuid*='UUID'::: *--uuid*='UUID':::
Set the unique extension ID in the metadata to 'UUID' Set the unique extension ID in the metadata to 'UUID'
*--gettext-domain*='DOMAIN':::
Set the gettext domain used by the extension
*--template*='TEMPLATE'::: *--template*='TEMPLATE':::
Use 'TEMPLATE' as base for the new extension Use 'TEMPLATE' as base for the new extension

20
subprojects/extensions-tool/src/command-create.c
View File

@ -135,6 +135,7 @@ create_metadata (GFile *target_dir,
const char *uuid, const char *uuid,
const char *name, const char *name,
const char *description, const char *description,
const char *gettext_domain,
GError **error) GError **error)
{ {
g_autofree char *uuid_escaped = NULL; g_autofree char *uuid_escaped = NULL;
@ -157,6 +158,10 @@ create_metadata (GFile *target_dir,
g_string_append_printf (json, " \"name\": \"%s\",\n", name_escaped); g_string_append_printf (json, " \"name\": \"%s\",\n", name_escaped);
g_string_append_printf (json, " \"description\": \"%s\",\n", desc_escaped); g_string_append_printf (json, " \"description\": \"%s\",\n", desc_escaped);
g_string_append_printf (json, " \"uuid\": \"%s\",\n", uuid_escaped); g_string_append_printf (json, " \"uuid\": \"%s\",\n", uuid_escaped);
if (gettext_domain)
g_string_append_printf (json, " \"gettext-domain\": \"%s\",\n", gettext_domain);
g_string_append_printf (json, " \"shell-version\": [\n"); g_string_append_printf (json, " \"shell-version\": [\n");
g_string_append_printf (json, " \"%s\"\n", version); g_string_append_printf (json, " \"%s\"\n", version);
g_string_append_printf (json, " ]\n}\n"); g_string_append_printf (json, " ]\n}\n");
@ -232,7 +237,11 @@ launch_extension_source (GFile *dir, GError **error)
} }
static gboolean static gboolean
create_extension (const char *uuid, const char *name, const char *description, const char *template) create_extension (const char *uuid,
const char *name,
const char *description,
const char *gettext_domain,
const char *template)
{ {
g_autoptr (GFile) dir = NULL; g_autoptr (GFile) dir = NULL;
g_autoptr (GError) error = NULL; g_autoptr (GError) error = NULL;
@ -252,7 +261,7 @@ create_extension (const char *uuid, const char *name, const char *description, c
return FALSE; return FALSE;
} }
if (!create_metadata (dir, uuid, name, description, &error)) if (!create_metadata (dir, uuid, name, description, gettext_domain, &error))
{ {
g_printerr ("%s\n", error->message); g_printerr ("%s\n", error->message);
return FALSE; return FALSE;
@ -422,6 +431,7 @@ handle_create (int argc, char *argv[], gboolean do_help)
g_autofree char *name = NULL; g_autofree char *name = NULL;
g_autofree char *description = NULL; g_autofree char *description = NULL;
g_autofree char *uuid = NULL; g_autofree char *uuid = NULL;
g_autofree char *gettext_domain = NULL;
g_autofree char *template = NULL; g_autofree char *template = NULL;
gboolean interactive = FALSE; gboolean interactive = FALSE;
gboolean list_templates = FALSE; gboolean list_templates = FALSE;
@ -438,6 +448,10 @@ handle_create (int argc, char *argv[], gboolean do_help)
.arg_description = _("DESCRIPTION"), .arg_description = _("DESCRIPTION"),
.arg = G_OPTION_ARG_STRING, .arg_data = &description, .arg = G_OPTION_ARG_STRING, .arg_data = &description,
.description = _("A short description of what the extension does") }, .description = _("A short description of what the extension does") },
{ .long_name = "gettext-domain",
.arg_description = _("DOMAIN"),
.arg = G_OPTION_ARG_STRING, .arg_data = &gettext_domain,
.description = _("The gettext domain used by the extension") },
{ .long_name = "template", { .long_name = "template",
.arg = G_OPTION_ARG_STRING, .arg_data = &template, .arg = G_OPTION_ARG_STRING, .arg_data = &template,
.arg_description = _("TEMPLATE"), .arg_description = _("TEMPLATE"),
@ -502,5 +516,5 @@ handle_create (int argc, char *argv[], gboolean do_help)
return 1; return 1;
} }
return create_extension (uuid, name, description, template) ? 0 : 2; return create_extension (uuid, name, description, gettext_domain, template) ? 0 : 2;
} }